Skip to content

Conversation

@tonistiigi
Copy link
Member

Depends on #47142

@tonistiigi tonistiigi changed the title vendor: update buildkit to v0.15.0 rc1 vendor: update buildkit to v0.15.0-rc1 Jul 3, 2024
@thaJeztah
Copy link
Member

@tonistiigi reviews welcome on #47142 - if it LGTY, we can merge it.

@vvoland
Copy link
Contributor

vvoland commented Jul 5, 2024

@tonistiigi can be rebased

vendor.mod Outdated
go 1.21
go 1.21.0

toolchain go1.21.11
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be removed

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, yes, wanted to ask that; also curious if we could still keep the go1.21 (without .0), but maybe if doesn't allow that

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if we could still keep the go1.21 (without .0),

nope: docker/buildkit-syft-scanner#88 (comment)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sigh. i was afraid of that

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there some flag that can be added to vendor.sh so that this isn't automatically added. I'm not sure what changes triggered it but obviously I did not manually add this.

Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
@tonistiigi tonistiigi force-pushed the vendor-buildkit-v0.15.0-rc1 branch from bbfcef1 to 1787c36 Compare July 9, 2024 03:36
@tonistiigi tonistiigi marked this pull request as ready for review July 9, 2024 03:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants