Skip to content

api/types: move plugin types to api/types/plugin#48114

Merged
vvoland merged 2 commits intomoby:masterfrom
thaJeztah:api_types_move_plugin_types
Aug 5, 2025
Merged

api/types: move plugin types to api/types/plugin#48114
vvoland merged 2 commits intomoby:masterfrom
thaJeztah:api_types_move_plugin_types

Conversation

@thaJeztah
Copy link
Member

@thaJeztah thaJeztah commented Jul 2, 2024

- Description for the changelog

api/types: move plugin types to api/types/plugin

- A picture of a cute animal (not mandatory but encouraged)

@thaJeztah thaJeztah added area/api API status/2-code-review impact/deprecation kind/refactor PR's that refactor, or clean-up code area/go-sdk impact/go-sdk Noteworthy (compatibility changes) in the Go SDK labels Jul 2, 2024
@thaJeztah thaJeztah added this to the 28.0.0 milestone Jul 2, 2024
@thaJeztah thaJeztah self-assigned this Jul 2, 2024
@thaJeztah thaJeztah force-pushed the api_types_move_plugin_types branch 2 times, most recently from 63a73c5 to 375826e Compare July 2, 2024 17:58
@thaJeztah thaJeztah marked this pull request as ready for review July 2, 2024 18:08
@thaJeztah thaJeztah requested review from cpuguy83 and tianon as code owners July 2, 2024 18:08
@thaJeztah thaJeztah mentioned this pull request Jul 2, 2024
Merged
1 task
@thaJeztah
Copy link
Member Author

thaJeztah commented Jul 11, 2024

@vvoland @laurazard ptal ☺️

@thaJeztah
Copy link
Member Author

thaJeztah commented Jul 15, 2024

@corhere this one LGTY? (I think you mentioned it looked okay in the call 😅 )

corhere
corhere requested changes Jul 15, 2024
View reviewed changes
Copy link
Contributor

@corhere corhere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sadly, no.

corhere
corhere reviewed Jul 15, 2024
View reviewed changes
@thaJeztah thaJeztah mentioned this pull request Aug 13, 2024
Merged
@vvoland vvoland mentioned this pull request Aug 16, 2024
Merged
@thaJeztah thaJeztah force-pushed the api_types_move_plugin_types branch from 375826e to f26a18d Compare August 19, 2024 11:07
@thaJeztah thaJeztah force-pushed the api_types_move_plugin_types branch from f26a18d to 75eb11d Compare January 20, 2025 16:52
@thaJeztah thaJeztah modified the milestones: 28.0.0, 28.1.0 Feb 14, 2025
@vvoland vvoland modified the milestones: 28.1.0, 28.2.0 Apr 11, 2025
@thaJeztah thaJeztah modified the milestones: 28.2.0, 29.0.0 May 22, 2025
@thaJeztah thaJeztah force-pushed the api_types_move_plugin_types branch 3 times, most recently from 6e51e4c to 15dfc6a Compare July 25, 2025 23:08
@thaJeztah thaJeztah marked this pull request as draft July 25, 2025 23:08
@thaJeztah thaJeztah force-pushed the api_types_move_plugin_types branch 2 times, most recently from 6ea6019 to 7039208 Compare July 29, 2025 12:11
@thaJeztah thaJeztah added the release-blocker PRs we want to block a release on label Aug 1, 2025
@thaJeztah thaJeztah force-pushed the api_types_move_plugin_types branch 5 times, most recently from 34f90cd to 2a3af5e Compare August 5, 2025 12:52
@thaJeztah
api/types: move plugin types to api/types/plugin
c13266d 
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztah
fix error-capitalization
57256a9 
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztah thaJeztah force-pushed the api_types_move_plugin_types branch from 2a3af5e to 57256a9 Compare August 5, 2025 14:15
@thaJeztah thaJeztah marked this pull request as ready for review August 5, 2025 14:34
@thaJeztah
Copy link
Member Author

thaJeztah commented Aug 5, 2025

Rebased, and it's green 🎉

cc @vvoland @corhere ptal

@vvoland vvoland merged commit b99405e into moby:master Aug 5, 2025
205 of 208 checks passed
@thaJeztah thaJeztah deleted the api_types_move_plugin_types branch August 5, 2025 17:39
@austinvazquez austinvazquez mentioned this pull request Aug 5, 2025
Merged
@thaJeztah thaJeztah mentioned this pull request Aug 6, 2025
Merged
@dmcgowan dmcgowan mentioned this pull request Aug 6, 2025
Closed
This was referenced Sep 5, 2025
Merged
Merged
Merged
@dmcgowan dmcgowan mentioned this pull request Sep 24, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@corhere corhere corhere approved these changes

@vvoland vvoland vvoland approved these changes

@cpuguy83 cpuguy83 Awaiting requested review from cpuguy83

@tianon tianon Awaiting requested review from tianon tianon is a code owner

Assignees

@dmcgowan dmcgowan

@thaJeztah thaJeztah

@vvoland vvoland

Labels

area/api API area/go-sdk area/plugins impact/deprecation impact/go-sdk Noteworthy (compatibility changes) in the Go SDK kind/refactor PR's that refactor, or clean-up code release-blocker PRs we want to block a release on status/2-code-review

Projects

None yet

Milestone

29.0.0

Development

Successfully merging this pull request may close these issues.

4 participants

@thaJeztah @corhere @vvoland @dmcgowan