builder/dockerfile: assorted linting fixes, and remove LCOW leftover#47993
Merged
thaJeztah merged 4 commits intomoby:masterfrom Jun 17, 2024
Merged
builder/dockerfile: assorted linting fixes, and remove LCOW leftover#47993thaJeztah merged 4 commits intomoby:masterfrom
thaJeztah merged 4 commits intomoby:masterfrom
Conversation
It was only used in a single location, and other locations were shadowing the function through local variables. As it's a one-liner, inlining the code may be just as transparent. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
- imageMount was shadowing the imageMount type - copy was shadowing the copy builtin - container was shadowing the container import Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
- explicitly suppress some errors - use fmt.Fprintln instead of manually appending a newline - remove an outdated TODO; looking at the suggestion, it's not a realistic option Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
This was added in 7a7357d as part of the LCOW implementation. LCOW has been removed, and this option was no longer in use because of that. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
vvoland
approved these changes
Jun 17, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
builder/dockerfile: remove endsInSlash utility
It was only used in a single location, and other locations were shadowing
the function through local variables. As it's a one-liner, inlining the
code may be just as transparent.
builder/dockerfile: rename vars that shadowed types and builtins
builder/dockerfile: fix some minor linting issues
realistic option
builder/dockerfile: createDestInfo: remove platform arg (LCOW left-over)
This was added in 7a7357d as part of the
LCOW implementation. LCOW has been removed, and this option was no longer
in use because of that.
- A picture of a cute animal (not mandatory but encouraged)