hack/unit: Rerun failed flaky libnetwork tests#47553
Merged
vvoland merged 2 commits intomoby:masterfrom Oct 30, 2024
Merged
Conversation
90378b1 to
8ee717d
Compare
a932e50 to
ed56844
Compare
Contributor
Author
|
|
baeb165 to
57b97ab
Compare
libnetwork tests tend to be flaky (namely `TestNetworkDBIslands` and `TestNetworkDBCRUDTableEntries`). Move execution of tests which name has `TestFlaky` prefix to a separate gotestsum pass which allows them to be reran 4 times. On Windows, the libnetwork test execution is not split into a separate pass. Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com>
Mark the following tests as flaky: - TestNetworkDBCRUDTableEntry - TestNetworkDBCRUDTableEntries - TestNetworkDBIslands - TestNetworkDBNodeLeave Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com>
57b97ab to
9893520
Compare
robmry
approved these changes
Mar 20, 2024
akerouanton
approved these changes
Oct 30, 2024
2 tasks
This was referenced May 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
libnetwork tests tend to be flaky (namely
TestNetworkDBIslandsandTestNetworkDBCRUDTableEntries).Move execution of tests which name has
TestFlakyprefix to a separate gotestsum pass which allows them to be reran 4 times.On Windows, the libnetwork test execution is not split into a separate pass.
- What I did
Restored joy in creating PRs (hopefully).
- How I did it
- How to verify it
CI
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)