builder-next: fix missing lock in ensurelayer#47523
Merged
thaJeztah merged 1 commit intomoby:masterfrom Mar 7, 2024
Merged
Conversation
When this was called concurrently from the moby image exporter there could be a data race where a layer was written to the refs map when it was already there. In that case the reference count got mixed up and on release only one of these layers was actually released. Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
vvoland
approved these changes
Mar 7, 2024
Member
|
CI is failing because PR is missing a changelog entry in the description |
Contributor
|
Added a changelog description |
Member
|
oh! forgot to LGTM; let me do so 🙈 |
This was referenced Mar 7, 2024
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #46136
When this was called concurrently from the moby image exporter there could be a data race where a layer was written to the refs map when it was already there.
In that case the reference count got mixed up and on release only one of these layers was actually released.