c8d/pull: Output truncated id for Pulling fs layer#47454
Merged
vvoland merged 1 commit intomoby:masterfrom Feb 27, 2024
Merged
Conversation
All other progress updates are emitted with truncated id. ```diff $ docker pull --platform linux/amd64 alpine Using default tag: latest latest: Pulling from library/alpine -sha256:4abcf20661432fb2d719aaf90656f55c287f8ca915dc1c92ec14ff61e67fbaf8: Pulling fs layer +4abcf2066143: Download complete Digest: sha256:c5b1261d6d3e43071626931fc004f70149baeba2c8ec672bd4f27761f8e1ad6b Status: Image is up to date for alpine:latest docker.io/library/alpine:latest ``` Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com>
b78baf9 to
16aa7dd
Compare
Benehiko
approved these changes
Feb 27, 2024
rumpl
approved these changes
Feb 27, 2024
thaJeztah
reviewed
Feb 27, 2024
Comment on lines
+122
to
124
| id := stringid.TruncateID(desc.Digest.String()) | ||
| progress.Update(out, id, "Pulling fs layer") | ||
| } |
Member
There was a problem hiding this comment.
We really need to have a close look at these progress things. This should (really) be all part of the presentation, not the API. I realise we can't easily change all of that right now, so for now, it's probably OK to align with the existing behavior, but it's really nasty.
Also see;
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All other progress updates are emitted with truncated id.
- What I did
- How I did it
- How to verify it
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)