api: omit missing Created field from ImageInspect response#47450
Merged
thaJeztah merged 1 commit intomoby:masterfrom Feb 26, 2024
Merged
api: omit missing Created field from ImageInspect response#47450thaJeztah merged 1 commit intomoby:masterfrom
thaJeztah merged 1 commit intomoby:masterfrom
Conversation
Signed-off-by: Bjorn Neergaard <bjorn.neergaard@docker.com>
tianon
approved these changes
Feb 26, 2024
Member
|
This one probably will fail, asking for a change-log entry 😉 |
corhere
approved these changes
Feb 26, 2024
Member
|
(added cherry-pick labels to follow-up #47387 👍) |
Member
|
Can we still do this for v25 (as it already shipped), or is this considered a change to the API? |
Member
|
Discussed in a call, and the missing omitempty was an oversight, so to not complicate things too much, it's better to include it than to have 3 variants. |
vvoland
approved these changes
Feb 26, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Createdto0001-01-01T00:00:00Zon older API versions #47374Set the
Createdfield in image inspect toomitemptyso we don't return it when it is absent from the image config, as opposed to returning an empty string.