Skip to content

[25.0 backport] vendor: github.com/opencontainers/runc v1.1.12#47274

Merged
thaJeztah merged 1 commit intomoby:25.0from
thaJeztah:25.0_backport_bump_runc_1.1.12
Jan 31, 2024
Merged

[25.0 backport] vendor: github.com/opencontainers/runc v1.1.12#47274
thaJeztah merged 1 commit intomoby:25.0from
thaJeztah:25.0_backport_bump_runc_1.1.12

Conversation

@thaJeztah
Copy link
Member

@thaJeztah thaJeztah commented Jan 31, 2024

(cherry picked from commit b20dccb)

- What I did

- How I did it

- How to verify it

- Description for the changelog

- A picture of a cute animal (not mandatory but encouraged)

@thaJeztah
vendor: github.com/opencontainers/runc v1.1.12
4b63c47 
- release notes: https://github.com/opencontainers/runc/releases/tag/v1.1.12
- full diff: opencontainers/runc@v1.1.11...v1.1.12

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
(cherry picked from commit b20dccb)
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztah thaJeztah added this to the 25.0.2 milestone Jan 31, 2024
laurazard
laurazard approved these changes Jan 31, 2024
View reviewed changes
Copy link
Member

@laurazard laurazard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vvoland
Copy link
Contributor

vvoland commented Jan 31, 2024

Weird failure:

=== FAIL: amd64.integration-cli TestDockerCLIPluginsSuite/TestPluginMetricsCollector (12.15s)
    docker_cli_plugins_test.go:469: assertion failed: r.Error is not nil: latest: Pulling from cpuguy83/docker-metrics-plugin-test
        Digest: sha256:6d4eea181eda6ff933093ec04d1b26a4c26b3a620263140a986158be8192a882
        a67d4c51c505: Waiting
        a67d4c51c505: Pulling fs layer
        a67d4c51c505: Complete
        a67d4c51c505: Download complete
        incorrect privileges

probably just flaky though

@thaJeztah
Copy link
Member Author

thaJeztah commented Jan 31, 2024

Failure looks unrelated;

=== Failed
=== FAIL: amd64.integration-cli TestDockerCLIPluginsSuite/TestPluginMetricsCollector (12.15s)
    docker_cli_plugins_test.go:469: assertion failed: r.Error is not nil: latest: Pulling from cpuguy83/docker-metrics-plugin-test
        Digest: sha256:6d4eea181eda6ff933093ec04d1b26a4c26b3a620263140a986158be8192a882
        a67d4c51c505: Waiting
        a67d4c51c505: Pulling fs layer
        a67d4c51c505: Complete
        a67d4c51c505: Download complete
        incorrect privileges
        
    --- FAIL: TestDockerCLIPluginsSuite/TestPluginMetricsCollector (12.15s)

@thaJeztah
Copy link
Member Author

thaJeztah commented Jan 31, 2024

Oh! LOL sorry for the double post; blame browser cache.

Everything else is green; bringing this one in

@thaJeztah thaJeztah merged commit b73ee94 into moby:25.0 Jan 31, 2024
@thaJeztah thaJeztah deleted the 25.0_backport_bump_runc_1.1.12 branch January 31, 2024 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vvoland vvoland vvoland approved these changes

@laurazard laurazard laurazard approved these changes

Assignees

No one assigned

Labels

area/runtime Runtime status/2-code-review status/4-merge

Projects

None yet

Milestone

25.0.2

Development

Successfully merging this pull request may close these issues.

3 participants

@thaJeztah @vvoland @laurazard