Skip to content

hack/make.ps1: Fix go list pattern#47264

Merged
thaJeztah merged 1 commit intomoby:masterfrom
vvoland:ci-fix-makeps1-templatefail
Jan 31, 2024
Merged

hack/make.ps1: Fix go list pattern#47264
thaJeztah merged 1 commit intomoby:masterfrom
vvoland:ci-fix-makeps1-templatefail

Conversation

@vvoland
Copy link
Contributor

@vvoland vvoland commented Jan 31, 2024 •
edited
Loading

The double quotes inside a single quoted string don't need to be escaped.
Looks like different Powershell versions are treating this differently and it started failing unexpectedly without any changes on our side.

- What I did

- How I did it

- How to verify it

- Description for the changelog

- A picture of a cute animal (not mandatory but encouraged)

@vvoland vvoland self-assigned this Jan 31, 2024
@thaJeztah
Copy link
Member

thaJeztah commented Jan 31, 2024

Thanks! Do we understand why it used to work before (and still does ... but not always?)

@tianon
Copy link
Member

tianon commented Jan 31, 2024

Maybe different versions of PowerShell handled the escaping here slightly differently? 😬

@tianon
Copy link
Member

tianon commented Jan 31, 2024

Tested successfully and it worked/quoted correctly on both my older powershell and @yosifkit's up-to-date powershell 7

@thaJeztah
Copy link
Member

thaJeztah commented Jan 31, 2024

Failure is a known flaky and tracked elsewhere

=== FAIL: amd64.integration.system TestDiskUsage/empty (0.00s)
    disk_usage_test.go:41: assertion failed: 
        --- du
        +++ →
          types.DiskUsage{
        - 	LayersSize: 4096,
        + 	LayersSize: 0,
          	Images:     {},
          	Containers: {},
          	... // 3 identical fields
          }

@vvoland
hack/make.ps1: Fix go list pattern
ecb217c 
The double quotes inside a single quoted string don't need to be
escaped.
Looks like different Powershell versions are treating this differently
and it started failing unexpectedly without any changes on our side.

Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com>
This was referenced Jan 31, 2024
Merged
Merged
@vvoland vvoland mentioned this pull request Jan 31, 2024
Merged
@vvoland vvoland force-pushed the ci-fix-makeps1-templatefail branch from 58a3e9f to ecb217c Compare January 31, 2024 19:01
@vvoland vvoland marked this pull request as ready for review January 31, 2024 19:01
@vvoland vvoland added this to the 26.0.0 milestone Jan 31, 2024
@thaJeztah
Copy link
Member

thaJeztah commented Jan 31, 2024

LOL, think you had 'em all, now it's golang's proxy doing a whoopsie;

go: downloading github.com/crazy-max/gotestlist v0.3.1
go: github.com/crazy-max/gotestlist/cmd/gotestlist@v0.3.1: github.com/crazy-max/gotestlist@v0.3.1: verifying module: github.com/crazy-max/gotestlist@v0.3.1: reading https://sum.golang.org/tile/8/0/x060/473: 404 Not Found
	server response: not found
Error: Process completed with exit code 1.

@thaJeztah
Copy link
Member

thaJeztah commented Jan 31, 2024

Bringing this one in; Windows is green

@thaJeztah thaJeztah merged commit 8a81b9d into moby:master Jan 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tianon tianon tianon approved these changes

Assignees

@vvoland vvoland

Labels

area/testing kind/bugfix PR's that fix bugs platform/windows process/cherry-picked

Projects

None yet

Milestone

26.0.0

Development

Successfully merging this pull request may close these issues.

3 participants

@vvoland @thaJeztah @tianon