gha: update actions to account for node 16 deprecation by thaJeztah · Pull Request #47250 · moby/moby

thaJeztah · 2024-01-30T13:08:09Z

Noticed deprecation warnings in CI:

Please update the following actions to use Node.js 20: actions/checkout@v3, actions/github-script@v6. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.

⚠️ I did not update the actions below; but I think these had compatibility issues:

actions/upload-artifact@v3
actions/download-artifact@v3
actions/cache@v3

gha: update to actions/checkout@v4

Release notes:

actions/checkout@v3.6.0...v4.1.1

gha: update to actions/github-script@v7

full diff: actions/github-script@v6.4.1...v7.0.1

breaking changes: https://github.com/actions/github-script?tab=readme-ov-file#v7

Version 7 of this action updated the runtime to Node 20
https://docs.github.com/en/actions/creating-actions/metadata-syntax-for-github-actions#runs-for-javascript-actions

All scripts are now run with Node 20 instead of Node 16 and are affected
by any breaking changes between Node 16 and 20

The previews input now only applies to GraphQL API calls as REST API previews
are no longer necessary
https://github.blog/changelog/2021-10-14-rest-api-preview-promotions/.

gha: update to actions/setup-go@v5

full diff: actions/setup-go@v3.5.0...v5.0.0

v5

In scope of this release, we change Nodejs runtime from node16 to node20.
Moreover, we update some dependencies to the latest versions.

Besides, this release contains such changes as:

Fix hosted tool cache usage on windows
Improve documentation regarding dependencies caching

V4

The V4 edition of the action offers:

Enabled caching by default
The action will try to enable caching unless the cache input is explicitly
set to false.

Please see "Caching dependency files and build outputs" for more information:
https://github.com/actions/setup-go#caching-dependency-files-and-build-outputs

gha: update to docker/metadata-action@v5

Node 20 as default runtime (requires Actions Runner v2.308.0 or later)
full diff: docker/metadata-action@v4.6.0...v5.5.0

gha: update to docker/setup-buildx-action@v3

Node 20 as default runtime (requires Actions Runner v2.308.0 or later)
full diff: docker/setup-buildx-action@v2.10.0...v3.0.0

gha: update to docker/bake-action@v4

Node 20 as default runtime (requires Actions Runner v2.308.0 or later)
full diff docker/bake-action@v2.3.0...v4.1.0

gha: update to docker/setup-qemu-action@v3

Node 20 as default runtime (requires Actions Runner v2.308.0 or later)
full diff docker/setup-qemu-action@v2.2.0...v3.0.0

gha: update to docker/login-action@v3

Node 20 as default runtime (requires Actions Runner v2.308.0 or later)
full diff docker/login-action@v2.2.0...v3.0.0

gha: update to crazy-max/ghaction-github-runtime@v3

Node 20 as default runtime (requires Actions Runner v2.308.0 or later)
full diff: crazy-max/ghaction-github-runtime@v2.2.0...v3.0.0

- Description for the changelog

- A picture of a cute animal (not mandatory but encouraged)

thaJeztah · 2024-01-30T13:11:48Z

Looks like some changes are needed;

Run mv "cwd:///home/runner/work/_temp/docker-actions-toolkit-tAvNLJ/docker-metadata-action-bake.json" "/tmp/bake-meta.json"
mv: cannot stat 'cwd:///home/runner/work/_temp/docker-actions-toolkit-tAvNLJ/docker-metadata-action-bake.json': No such file or directory
Error: Process completed with exit code 1.

moby/.github/workflows/bin-image.yml

Line 65 in 794f712

mv "${{ steps.meta.outputs.bake-file }}" "/tmp/bake-meta.json"

moby/.github/workflows/bin-image.yml

Lines 177 to 183 in 794f712

    
                     docker buildx imagetools create $(jq -cr '.target."docker-metadata-action".tags | map("-t " + .) | join(" ")' /tmp/bake-meta.json) \ 
        
                       $(printf '${{ env.MOBYBIN_REPO_SLUG }}@sha256:%s ' *) 
        
                 - 
        
                   name: Inspect image 
        
                   run: | 
        
                     set -x 
        
                     docker buildx imagetools inspect ${{ env.MOBYBIN_REPO_SLUG }}:$(jq -cr '.target."docker-metadata-action".args.DOCKER_META_VERSION' /tmp/bake-meta.json)

crazy-max · 2024-01-31T09:29:25Z

Looks like some changes are needed;
Run mv "cwd:///home/runner/work/_temp/docker-actions-toolkit-tAvNLJ/docker-metadata-action-bake.json" "/tmp/bake-meta.json"
mv: cannot stat 'cwd:///home/runner/work/_temp/docker-actions-toolkit-tAvNLJ/docker-metadata-action-bake.json': No such file or directory
Error: Process completed with exit code 1.
moby/.github/workflows/bin-image.yml

Line 65 in 794f712

mv "${{ steps.meta.outputs.bake-file }}" "/tmp/bake-meta.json"

moby/.github/workflows/bin-image.yml

Lines 177 to 183 in 794f712

docker buildx imagetools create $(jq -cr '.target."docker-metadata-action".tags | map("-t " + .) | join(" ")' /tmp/bake-meta.json) \

$(printf '${{ env.MOBYBIN_REPO_SLUG }}@sha256:%s ' *)

-

name: Inspect image

run: |

set -x

docker buildx imagetools inspect ${{ env.MOBYBIN_REPO_SLUG }}:$(jq -cr '.target."docker-metadata-action".args.DOCKER_META_VERSION' /tmp/bake-meta.json)

Ah yes this is related to docker/metadata-action#381, see docker/metadata-action#381 (comment) as workaround in the meantime

Release notes: - actions/checkout@v3.6.0...v4.1.1 Signed-off-by: Sebastiaan van Stijn <github@gone.nl>

- full diff: actions/github-script@v6.4.1...v7.0.1 breaking changes: https://github.com/actions/github-script?tab=readme-ov-file#v7 > Version 7 of this action updated the runtime to Node 20 > https://docs.github.com/en/actions/creating-actions/metadata-syntax-for-github-actions#runs-for-javascript-actions > > All scripts are now run with Node 20 instead of Node 16 and are affected > by any breaking changes between Node 16 and 20 > > The previews input now only applies to GraphQL API calls as REST API previews > are no longer necessary > https://github.blog/changelog/2021-10-14-rest-api-preview-promotions/. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>

- full diff: actions/setup-go@v3.5.0...v5.0.0 v5 In scope of this release, we change Nodejs runtime from node16 to node20. Moreover, we update some dependencies to the latest versions. Besides, this release contains such changes as: - Fix hosted tool cache usage on windows - Improve documentation regarding dependencies caching V4 The V4 edition of the action offers: - Enabled caching by default - The action will try to enable caching unless the cache input is explicitly set to false. Please see "Caching dependency files and build outputs" for more information: https://github.com/actions/setup-go#caching-dependency-files-and-build-outputs Signed-off-by: Sebastiaan van Stijn <github@gone.nl>

- Node 20 as default runtime (requires Actions Runner v2.308.0 or later) - full diff: docker/metadata-action@v4.6.0...v5.5.0 Signed-off-by: Sebastiaan van Stijn <github@gone.nl>

- Node 20 as default runtime (requires Actions Runner v2.308.0 or later) - full diff: docker/setup-buildx-action@v2.10.0...v3.0.0 Signed-off-by: Sebastiaan van Stijn <github@gone.nl>

- Node 20 as default runtime (requires Actions Runner v2.308.0 or later) - full diff docker/bake-action@v2.3.0...v4.1.0 Signed-off-by: Sebastiaan van Stijn <github@gone.nl>

- Node 20 as default runtime (requires Actions Runner v2.308.0 or later) - full diff docker/setup-qemu-action@v2.2.0...v3.0.0 Signed-off-by: Sebastiaan van Stijn <github@gone.nl>

- Node 20 as default runtime (requires Actions Runner v2.308.0 or later) - full diff docker/login-action@v2.2.0...v3.0.0 Signed-off-by: Sebastiaan van Stijn <github@gone.nl>

- Node 20 as default runtime (requires Actions Runner v2.308.0 or later) - full diff: crazy-max/ghaction-github-runtime@v2.2.0...v3.0.0 Signed-off-by: Sebastiaan van Stijn <github@gone.nl>

thaJeztah · 2024-01-31T10:47:11Z

.github/workflows/bin-image.yml

        name: Rename meta bake definition file
+        # see https://github.com/docker/metadata-action/issues/381#issuecomment-1918607161
        run: |
-          mv "${{ steps.meta.outputs.bake-file }}" "/tmp/bake-meta.json"
+          bakeFile="${{ steps.meta.outputs.bake-file }}"
+          mv "${bakeFile#cwd://}" "/tmp/bake-meta.json"


Updated this commit to have the suggested changes

thaJeztah · 2024-01-31T10:47:23Z

Thanks @crazy-max - looks like that resolved the issue; PTAL 🤗

thaJeztah · 2024-01-31T10:49:15Z

Looks like the remaining warnings are for the upload- and download-artifact actions; let's do those in a follow-up (as additional changes may be needed for that one?)

crazy-max · 2024-01-31T11:08:24Z

Looks like the remaining warnings are for the upload- and download-artifact actions; let's do those in a follow-up (as additional changes may be needed for that one?)

Yes will do the artifact actions bump in follow-up

thaJeztah · 2024-01-31T11:45:25Z

Let me bring this one in; thanks!

thaJeztah added status/2-code-review area/testing process/cherry-pick/23.0 process/cherry-pick/24.0 process/cherry-pick/25.0 labels Jan 30, 2024

thaJeztah added this to the 26.0.0 milestone Jan 30, 2024

thaJeztah self-assigned this Jan 30, 2024

thaJeztah added 9 commits January 31, 2024 10:46

gha: update to actions/checkout@v4

0ffddc6

Release notes: - actions/checkout@v3.6.0...v4.1.1 Signed-off-by: Sebastiaan van Stijn <github@gone.nl>

gha: update to docker/metadata-action@v5

00a2626

- Node 20 as default runtime (requires Actions Runner v2.308.0 or later) - full diff: docker/metadata-action@v4.6.0...v5.5.0 Signed-off-by: Sebastiaan van Stijn <github@gone.nl>

gha: update to docker/setup-buildx-action@v3

b7fd571

- Node 20 as default runtime (requires Actions Runner v2.308.0 or later) - full diff: docker/setup-buildx-action@v2.10.0...v3.0.0 Signed-off-by: Sebastiaan van Stijn <github@gone.nl>

gha: update to docker/bake-action@v4

4a1839e

- Node 20 as default runtime (requires Actions Runner v2.308.0 or later) - full diff docker/bake-action@v2.3.0...v4.1.0 Signed-off-by: Sebastiaan van Stijn <github@gone.nl>

gha: update to docker/setup-qemu-action@v3

5d396e0

- Node 20 as default runtime (requires Actions Runner v2.308.0 or later) - full diff docker/setup-qemu-action@v2.2.0...v3.0.0 Signed-off-by: Sebastiaan van Stijn <github@gone.nl>

gha: update to docker/login-action@v3

0825197

- Node 20 as default runtime (requires Actions Runner v2.308.0 or later) - full diff docker/login-action@v2.2.0...v3.0.0 Signed-off-by: Sebastiaan van Stijn <github@gone.nl>

gha: update to crazy-max/ghaction-github-runtime@v3

3a81912

- Node 20 as default runtime (requires Actions Runner v2.308.0 or later) - full diff: crazy-max/ghaction-github-runtime@v2.2.0...v3.0.0 Signed-off-by: Sebastiaan van Stijn <github@gone.nl>

thaJeztah force-pushed the update_actions branch from 2335bf8 to 3a81912 Compare January 31, 2024 09:50

thaJeztah commented Jan 31, 2024

View reviewed changes

crazy-max approved these changes Jan 31, 2024

View reviewed changes

thaJeztah merged commit 2df4755 into moby:master Jan 31, 2024

thaJeztah deleted the update_actions branch January 31, 2024 11:45

This was referenced Jan 31, 2024

ci: bump remaining gha to latest stable #47263

Merged

ci: update gha to account for node 16 deprecation moby/buildkit#4605

Merged

thaJeztah mentioned this pull request Feb 1, 2024

[25.0 backport] gha: update actions to account for node 16 deprecation #47291

Merged

thaJeztah mentioned this pull request Feb 1, 2024

[24.0 backport] gha: update actions to account for node 16 deprecation #47292

Closed

thaJeztah removed the process/cherry-pick/25.0 label Feb 3, 2024

thaJeztah removed the process/cherry-pick/24.0 label Jun 8, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

gha: update actions to account for node 16 deprecation #47250

gha: update actions to account for node 16 deprecation #47250
thaJeztah merged 9 commits intomoby:masterfrom
thaJeztah:update_actions

thaJeztah commented Jan 30, 2024

Uh oh!

thaJeztah commented Jan 30, 2024 •

edited

Loading

Uh oh!

crazy-max commented Jan 31, 2024

Uh oh!

thaJeztah Jan 31, 2024

Uh oh!

thaJeztah commented Jan 31, 2024

Uh oh!

thaJeztah commented Jan 31, 2024

Uh oh!

crazy-max commented Jan 31, 2024 •

edited by thaJeztah

Loading

Uh oh!

thaJeztah commented Jan 31, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

thaJeztah commented Jan 30, 2024

gha: update to actions/checkout@v4

gha: update to actions/github-script@v7

gha: update to actions/setup-go@v5

gha: update to docker/metadata-action@v5

gha: update to docker/setup-buildx-action@v3

gha: update to docker/bake-action@v4

gha: update to docker/setup-qemu-action@v3

gha: update to docker/login-action@v3

gha: update to crazy-max/ghaction-github-runtime@v3

Uh oh!

thaJeztah commented Jan 30, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

crazy-max commented Jan 31, 2024

Uh oh!

thaJeztah Jan 31, 2024

Choose a reason for hiding this comment

Uh oh!

thaJeztah commented Jan 31, 2024

Uh oh!

thaJeztah commented Jan 31, 2024

Uh oh!

crazy-max commented Jan 31, 2024 • edited by thaJeztah Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

thaJeztah commented Jan 31, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

thaJeztah commented Jan 30, 2024 •

edited

Loading

crazy-max commented Jan 31, 2024 •

edited by thaJeztah

Loading