Skip to content

Conversation

@thaJeztah
Copy link
Member

@thaJeztah thaJeztah commented Jan 20, 2024

This matcher was only used internally in the containerd implementation of the image store. Un-export it, and make it a local utility in that package to prevent external use.

This package was introduced in 1616a09 (v24.0), and there are no known external consumers of this package, so there should be no need to deprecate / alias the old location.

- Description for the changelog

- A picture of a cute animal (not mandatory but encouraged)

@thaJeztah thaJeztah added status/2-code-review area/images Image Distribution kind/refactor PR's that refactor, or clean-up code labels Jan 20, 2024
@thaJeztah thaJeztah added this to the 26.0.0 milestone Jan 20, 2024
@thaJeztah thaJeztah self-assigned this Jan 20, 2024
@thaJeztah thaJeztah mentioned this pull request Jan 20, 2024
79 tasks
This matcher was only used internally in the containerd implementation of
the image store. Un-export it, and make it a local utility in that package
to prevent external use.

This package was introduced in 1616a09
(v24.0), and there are no known external consumers of this package, so there
should be no need to deprecate / alias the old location.

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztah thaJeztah force-pushed the internalize_pkg_platforms branch from 9717615 to 94b4765 Compare January 20, 2024 21:29
Copy link
Member

@rumpl rumpl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/images Image Distribution kind/refactor PR's that refactor, or clean-up code status/2-code-review

Projects

Development

Successfully merging this pull request may close these issues.

2 participants