libnetwork: loosen container IPAM validation#47132
Merged
thaJeztah merged 1 commit intomoby:masterfrom Jan 20, 2024
Merged
Conversation
Permit container network attachments to set any static IP address within the network's IPAM master pool, including when a subpool is configured. Users have come to depend on being able to statically assign container IP addresses which are guaranteed not to collide with automatically- assigned container addresses. Signed-off-by: Cory Snider <csnider@mirantis.com>
thaJeztah
reviewed
Jan 20, 2024
| assert.Equal(t, c.NetworkSettings.Networks["testnet"].MacAddress, "02:42:08:26:a9:55") | ||
| } | ||
|
|
||
| func TestStaticIPOutsideSubpool(t *testing.T) { |
Member
There was a problem hiding this comment.
Perhaps it's useful to add a description to the test (based on your PR description on GitHub); this seems like one of those cases where context may be useful to know "why" this test is.
thaJeztah
approved these changes
Jan 20, 2024
Member
thaJeztah
left a comment
There was a problem hiding this comment.
LGTM (left a suggestion for the test)
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
- What I did
Permit container network attachments to set any static IP address within the network's IPAM master pool, including when a subpool is configured. Users have come to depend on being able to statically assign container IP addresses which are guaranteed not to collide with automatically- assigned container addresses.
- How I did it
By deleting a couple lines of code
- How to verify it
New regression test
- Description for the changelog
--ip-rangeof a container network- A picture of a cute animal (not mandatory but encouraged)