Make sure that make doesn't rm -rf the system out of existence#47121
Merged
thaJeztah merged 1 commit intomoby:masterfrom Jan 23, 2024
Merged
Make sure that make doesn't rm -rf the system out of existence#47121thaJeztah merged 1 commit intomoby:masterfrom
thaJeztah merged 1 commit intomoby:masterfrom
Conversation
Signed-off-by: voloder <110066198+voloder@users.noreply.github.com>
AkihiroSuda
approved these changes
Jan 22, 2024
vvoland
approved these changes
Jan 22, 2024
laurazard
approved these changes
Jan 22, 2024
Contributor
Author
|
I tried to find conditions in which this would occur "normally". I only got so far as to chmod'ing the tmp directory and getting |
crazy-max
approved these changes
Jan 22, 2024
Member
|
Thanks! Let's bring this one in. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
- What I did
Ensure that make raises an error if
mktemp, for whatever reason, returns an empty string. This could possibly happen if, for some reason, the/tmpdirectory was chown'd or there was no free space left on the system.This pull request makes sure that it won't
rm -rf /*the system out of existence in case$@_TMP_OUTis an empty string.If
$($@_TMP_OUT)was empty,would evaluate to
What would happen next is up to your imagination
- How I did it
I did it by adding
after
in the Makefile
- How to verify it
Run
make generate-files- Description for the changelog