c8d/exporter: Use WithSkipMissing#46978
Conversation
| return presentManifests[0], nil | ||
| } else if len(presentManifests) == 0 { | ||
| // Return error when none of the image's manifest is present. | ||
| return none, errdefs.NotFound(fmt.Errorf("none of the manifests is fully present in the content store")) |
There was a problem hiding this comment.
Wondering if we want to have a utility / check around to allow returning a warning.
I think it makes sense to allow exporting "whatever is in the store" (even if partial content), but possibly we want to have;
- a warning
- an option to create a new variant of the image with only the available variants (and thus; new digest)
Not exactly sure yet what the "UX" for it would be, and if that would require adding an option to the API ("export policy" or whatever)
|
Related PR in containerd; |
|
containerd 1.7.12 was tagged, and I updated my existing PR that updates it (and moves some dependency); that should unblock this PR |
Save the unmodified manifest list to keep the image ID of the multi-platform images when not all platforms are present. Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com>
de234b3 to
2a02403
Compare
|
Moved this out of draft; IIUC, the remaining bits in BuildKit are "nice to have" but those missing are not troublesome; this implementation is a lot cleaner though to what was there before, so I think it'd be nice to have this in. |
|
Let me bring this one in 👍 |
Save the unmodified manifest list to keep the image ID of the multi-platform images when not all platforms are present.
Note: Without moby/buildkit#4558 vendored copying the distribution source labels into the
index.jsonannotations won't work: containerd/containerd@b9af453 (for OCI archives exported directly from buildkit).- What I did
- How I did it
- How to verify it
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)