c8d/docker-py: Temporarily skip test_commit_*#46966
Merged
thaJeztah merged 1 commit intomoby:masterfrom Dec 19, 2023
Merged
Conversation
54 tasks
Contributor
Author
|
Not LGTM! 🙈 (bad Fixture name) tests/integration/api_image_test.py:89: in test_commit
assert img['Container'].startswith(id)
E AssertionError: assert False
E + where False = <built-in method startswith of str object at 0x7f24d3aeacf0>('7f52ce4bc498f278121efa4247509994a12532c088f22bc3dfcba6354c22cb74')
E + where <built-in method startswith of str object at 0x7f24d3aeacf0> = ''.startswith
_____________________ CommitTest.test_commit_with_changes ______________________
tests/integration/api_image_test.py:107: in test_commit_with_changes
assert img['Container'].startswith(cid['Id'])
E AssertionError: assert False
E + where False = <built-in method startswith of str object at 0x7f24d3aeacf0>('f3cad02b1ad03d6e3f0bc5527f2097d8f68d14d2a1656cd59f12151476fd0c83')
E + where <built-in method startswith of str object at 0x7f24d3aeacf0> = ''.startswith |
These tests check deprecated fields. Reenable them once a new docker-py is released. Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com>
b86d357 to
f6a160d
Compare
Contributor
Author
|
Should be fine now! Sorry 🤦🏻 |
Member
|
Doh! I thought I checked the build, but maybe I did for the other one 🙈 |
Contributor
Author
|
Only the cache test is failing now 🎉 |
rumpl
approved these changes
Dec 19, 2023
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ContainerandContainerConfigfor/images/{id}/json#46939These tests check deprecated fields. Reenable them once a new docker-py is released.
- What I did
- How I did it
- How to verify it
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)