Skip to content

c8d/docker-py: Temporarily skip test_save_and_load*#46965

Merged
thaJeztah merged 1 commit intomoby:masterfrom
vvoland:c8d-dockerpy-skip-imagesaveload
Dec 19, 2023
Merged

c8d/docker-py: Temporarily skip test_save_and_load*#46965
thaJeztah merged 1 commit intomoby:masterfrom
vvoland:c8d-dockerpy-skip-imagesaveload

Conversation

@vvoland
Copy link
Contributor

@vvoland vvoland commented Dec 19, 2023

They fail because exporting an image which targets a manifest list when only one platform is available exports only the platform-specific manifest and the ID of the loaded image is different (ID of the platform manifest, not manifest list).

They will be reenabled once we have the containerd changes which allow loading archives containing a manifest list referencing platforms that are not included in the archive.

They fail because exporting an image which targets a manifest list when
only one platform is available exports only the platform-specific
manifest so the ID of the loaded image is different (ID of the platform
manifest, not manifest list).

Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com>
@vvoland vvoland added status/2-code-review area/testing containerd-integration Issues and PRs related to containerd integration labels Dec 19, 2023
@vvoland vvoland added this to the 25.0.0 milestone Dec 19, 2023
@vvoland vvoland self-assigned this Dec 19, 2023
@vvoland vvoland requested a review from tianon as a code owner December 19, 2023 11:04
Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thaJeztah
Copy link
Member

Looks like (unrelated) docker-py needs an update for some deprecated feature as well;

=============================== warnings summary ===============================
tests/integration/client_test.py::CancellableEventsTest::test_cancel_events
  /src/docker/utils/utils.py:398: DeprecationWarning: datetime.datetime.utcfromtimestamp() is deprecated and scheduled for removal in a future version. Use timezone-aware objects to represent datetimes in UTC: datetime.datetime.fromtimestamp(timestamp, datetime.UTC).
    delta = dt - datetime.utcfromtimestamp(0)

@thaJeztah thaJeztah merged commit ae726dc into moby:master Dec 19, 2023
@thaJeztah thaJeztah mentioned this pull request Jan 17, 2024
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/testing containerd-integration Issues and PRs related to containerd integration status/2-code-review

Projects

Development

Successfully merging this pull request may close these issues.

2 participants