c8d/inspect: Fill Parent property#46912
Merged
vvoland merged 1 commit intomoby:masterfrom Dec 18, 2023
Merged
Conversation
54 tasks
thaJeztah
reviewed
Dec 8, 2023
Member
|
Doh! This needs a rebase now |
4e65bcb to
146e571
Compare
rumpl
approved these changes
Dec 13, 2023
146e571 to
f266742
Compare
Contributor
Author
|
hmm some linting issue: |
thaJeztah
reviewed
Dec 18, 2023
Before this change `ParentId` was filled for images when calling the `/images/json` (image list) endpoint but was not for the `/images/<image>/json` (image inspect). Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com>
f266742 to
18b1aec
Compare
Member
|
LOL, race-condition in our comments; yup, just spotted that issue (was about to merge, but checked if only failures were in the containerd checks 😂) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before this change
ParentIdwas filled for images when calling the/images/json(image list) endpoint but was not for the/images/<image>/json(image inspect).This fixes part of
tests.integration.api_image_test.CommitTestandtests.integration.api_image_test.CommitTest(not fully though, only theParentvalue check).- What I did
- How I did it
- How to verify it
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)