c8d/integration-cli: Adjust TestBuildClearCmd#46907
Merged
thaJeztah merged 1 commit intomoby:masterfrom Dec 7, 2023
Merged
Conversation
Config serialization performed by the graphdriver implementation maintained the distinction between an empty array and having no Cmd set. With containerd integration we serialize the OCI types directly that use the `omitempty` option which doesn't persist that distinction. Considering that both values should have exactly the same semantics (no cmd being passed) it should be fine if in this case the Cmd would be null instead of an empty array. Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com>
rumpl
approved these changes
Dec 7, 2023
54 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Config serialization performed by the graphdriver implementation maintained the distinction between an empty array and having no
Cmdset.With containerd integration we serialize the OCI types directly that use the
omitemptyoption which doesn't persist that distinction.Considering that both values should have exactly the same semantics (no cmd being passed) it should be fine if in this case the Cmd would be null instead of an empty array.
- What I did
- How I did it
- How to verify it
TestBuildClearCmd- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)