integration/prune: Run in a separate daemon#46896
Merged
thaJeztah merged 1 commit intomoby:masterfrom Dec 7, 2023
Merged
Conversation
54 tasks
2ed437b to
150963b
Compare
150963b to
a9e0daf
Compare
a9e0daf to
036735b
Compare
thaJeztah
reviewed
Dec 7, 2023
integration/image/prune_test.go
Outdated
|
|
||
| for _, deleted := range pruned.ImagesDeleted { | ||
| if strings.Contains(deleted.Deleted, danglingID) || strings.Contains(deleted.Untagged, danglingID) { | ||
| t.Fatalf("used dangling image %s shouldn't be deleted", danglingID) |
Member
There was a problem hiding this comment.
This one could probably be t.Errorf (as we're looping over a range?) or do we want to fail fast always?
Contributor
Author
There was a problem hiding this comment.
Either is fine I think. Changed to Errorf. Thanks!
thaJeztah
approved these changes
Dec 7, 2023
Member
thaJeztah
left a comment
There was a problem hiding this comment.
LGTM, but left one minor comment
Isolate the prune effects by running the test in a separate daemon. This minimizes the impact of/on other integration tests. Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com>
036735b to
eaaf1ea
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Isolate the prune effects by running the test in a separate daemon.
This minimizes the impact of/on other integration tests.
- How to verify it
- Description for the changelog
TestPruneDontDeleteUsedDangling in CI
- A picture of a cute animal (not mandatory but encouraged)