cmd/dockerd: remove various cobra templating#46871
Merged
thaJeztah merged 2 commits intomoby:masterfrom Dec 1, 2023
Merged
Conversation
5 tasks
This removes various templating functions that were added for the docker CLI. These are not needed for the dockerd binary, which does not have subcommands or management commands. Revert "Only hide commands if the env variable is set." This reverts commit a7c8bca. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
a7b02e9 to
61d9485
Compare
AkihiroSuda
approved these changes
Dec 1, 2023
vvoland
approved these changes
Dec 1, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cmd/dockerd: remove various cobra templating
This removes various templating functions that were added for the
docker CLI. These are not needed for the dockerd binary, which does
not have subcommands or management commands.
Revert "Only hide commands if the env variable is set."
This reverts commit a7c8bca.
cmd/dockerd: make cobra templates a const
- How to verify it
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)