integration-cli/TestCrossRepositoryLayerPush: Change repo name#46855
Merged
thaJeztah merged 1 commit intomoby:masterfrom Nov 27, 2023
Merged
integration-cli/TestCrossRepositoryLayerPush: Change repo name#46855thaJeztah merged 1 commit intomoby:masterfrom
thaJeztah merged 1 commit intomoby:masterfrom
Conversation
Change the repo name used as for an intermediate image so it doesn't try to mount from the image pushed by `TestBuildMultiStageImplicitPull`. Before this patch, this test failed because the distribution.source labels are not cleared between tests and the busybox content still has the distribution.source label pointing to the `dockercli/testf` repository which is no longer present in the test registry. So both `dockercli/busybox` and `dockercli/testf` are equally valid mount candidates for `dockercli/crossrepopush` and containerd algorithm just happens to select the last one. This changes the repo name to not have the common repository component (`dockercli`) with the `dockercli/testf` repository. Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com>
54 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change the repo name used as for an intermediate image so it doesn't try to mount from the image pushed by
TestBuildMultiStageImplicitPull.Before this patch, this test failed because the distribution.source labels are not cleared between tests and the busybox content still has the distribution.source label pointing to the
dockercli/testfrepository which is no longer present in the test registry. So bothdockercli/busyboxanddockercli/testfare equally valid mount candidates fordockercli/crossrepopushand containerd algorithm just happens to select the last one.This changes the repo name to not have the common repository component (
dockercli) with thedockercli/testfrepository.- What I did
- How I did it
- How to verify it
Observe
TestCrossRepositoryLayerPushresult in CI.- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)