c8d: fix support for pull by digest#46819
Merged
thaJeztah merged 1 commit intomoby:masterfrom Nov 16, 2023
Merged
Conversation
Signed-off-by: Derek McGowan <derek@mcg.dev>
54 tasks
rumpl
approved these changes
Nov 16, 2023
Member
rumpl
left a comment
There was a problem hiding this comment.
Kicked the CI, it looks like it really does fix these tests :) LGTM
thaJeztah
approved these changes
Nov 16, 2023
Member
thaJeztah
left a comment
There was a problem hiding this comment.
LGTM
we really need to make "all" a separate option in the API (or to just require passing all refences)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull by digest regressed in #46618, causing a fallback to the pull all tags logic. The
pullTaglogic already properly handles tag or digest.Fixes at least 3 tests from containerd integration: