daemon/snapshotter: Align mounter implementations#46769
Merged
vvoland merged 1 commit intomoby:masterfrom Nov 3, 2023
Merged
Conversation
17d0219 to
fd233ee
Compare
rumpl
approved these changes
Nov 3, 2023
thaJeztah
reviewed
Nov 3, 2023
thaJeztah
approved these changes
Nov 3, 2023
Member
thaJeztah
left a comment
There was a problem hiding this comment.
LGTM; left one suggestion; let me know if you want to update before merge
Change the non-refcounted implementation to perform the mount using the same identity and access right. They should be the same regardless if we're refcounting or not. This also allows to refactor refCountMounter into a mounter decorator. Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com>
fd233ee to
26f6360
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
- What I did
Change the non-refcounted implementation to perform the mount using the same identity and access right. They should be the same regardless if we're refcounting or not.
This also allows to refactor
refCountMounterinto a mounter decorator.- How I did it
- How to verify it
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)