Skip TestPullManifestList when using containerd#46759
Merged
thaJeztah merged 1 commit intomoby:masterfrom Nov 3, 2023
Merged
Conversation
This test is very weird, the Size in the manifests that it creates is wrong, graph drivers only print a warning in that case but containerd fails because it verifies more things. The media types are also wrong in the containerd case, the manifest list forces the media type to be "schema2.MediaTypeManifest" but in the containerd case the media type is an OCI one. Signed-off-by: Djordje Lukic <djordje.lukic@docker.com>
thaJeztah
approved these changes
Nov 2, 2023
Member
thaJeztah
left a comment
There was a problem hiding this comment.
LGTM
And now I want to figure out what each of the steps in the test is actually testing. Honestly, no clue; it's really weird indeed.
54 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
- What I did
Skipped
TestPullManifestListwhen using containerdThis test is very weird, the
Sizein the manifests that it creates is wrong, graph drivers only print a warning in that case but containerd fails because it verifies more things. The media types are also wrong in the containerd case, the manifest list forces the media type to be "schema2.MediaTypeManifest" but in the containerd case the media type is an OCI one.- How I did it
- How to verify it
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)