Skip to content

c8d: Return the "tag does not exist error"#46685

Merged
cpuguy83 merged 1 commit intomoby:masterfrom
rumpl:c8d-tag-does-not-exist
Nov 2, 2023
Merged

c8d: Return the "tag does not exist error"#46685
cpuguy83 merged 1 commit intomoby:masterfrom
rumpl:c8d-tag-does-not-exist

Conversation

@rumpl
Copy link
Member

@rumpl rumpl commented Oct 20, 2023 •
edited
Loading

- What I did

In the tagged case the error message when the image/tag is not found should be "tag does not exist: ref"

With graph drivers:

$ docker push busybox:asdf
The push refers to repository [docker.io/library/busybox]
tag does not exist: busybox:asdf

With this change:

$ docker push busybox:asdf
The push refers to repository [docker.io/library/busybox]
- image "docker.io/library/busybox:asdf": not found
+ tag does not exist: busybox:asdf

- How I did it

- How to verify it

The test TestDockerRegistrySuite/TestPushBadTag should pass

- Description for the changelog

- A picture of a cute animal (not mandatory but encouraged)

@rumpl
c8d: Return the "tag does not exist error"
8166818 
In the tagged case the error message when the image/tag is not found
should be "tag does not exist: ref"

Signed-off-by: Djordje Lukic <djordje.lukic@docker.com>
@rumpl rumpl added status/2-code-review area/images Image Distribution containerd-integration Issues and PRs related to containerd integration labels Oct 20, 2023
thaJeztah
thaJeztah approved these changes Oct 21, 2023
View reviewed changes
Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cpuguy83
Copy link
Member

cpuguy83 commented Oct 21, 2023

Looks like some relevant failures related to this.

@rumpl
Copy link
Member Author

rumpl commented Oct 23, 2023

Looks like some relevant failures related to this.

I've looked at the failing tests twice and don't see the relevant failures you are talking about, which one did you see?

@rumpl
Copy link
Member Author

rumpl commented Oct 27, 2023

Looks like some relevant failures related to this.

I've looked at the failing tests twice and don't see the relevant failures you are talking about, which one did you see?

@cpuguy83 ping

@rumpl rumpl mentioned this pull request Nov 2, 2023
Closed
54 tasks
@cpuguy83
Copy link
Member

cpuguy83 commented Nov 2, 2023

@rumpl Sorry for the delayed response.
When I looked at it there were a bunch of failures related to the "tag does not exist" error.

@cpuguy83 cpuguy83 merged commit 2f138d8 into moby:master Nov 2, 2023
@thaJeztah thaJeztah added this to the 25.0.0 milestone Nov 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cpuguy83 cpuguy83 cpuguy83 approved these changes

@thaJeztah thaJeztah thaJeztah approved these changes

@laurazard laurazard laurazard approved these changes

Assignees

No one assigned

Labels

area/images Image Distribution containerd-integration Issues and PRs related to containerd integration status/2-code-review

Projects

containerd integration
Status: Done

Milestone

25.0.0

Development

Successfully merging this pull request may close these issues.

4 participants

@rumpl @cpuguy83 @thaJeztah @laurazard