c8d: Remove the panic from UpdateConfig#46433
Merged
thaJeztah merged 1 commit intomoby:masterfrom Sep 8, 2023
Merged
Conversation
We don't really want the daemon to panic for this so let's log a warning about max downloads and uploads Signed-off-by: Djordje Lukic <djordje.lukic@docker.com>
vvoland
approved these changes
Sep 8, 2023
sam-thibault
approved these changes
Sep 8, 2023
Member
|
Failiure is unrelated; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
- What I did
Remove the last panic from the image service, I only removed it, didn't fid the download/upload limits...
We don't really want the daemon to panic for this so let's log a warning about max downloads and uploads
- How I did it
- How to verify it
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)