integration-cli: Skip TestRmiParentImageFail when using c8d snapshotters#46432
Merged
thaJeztah merged 1 commit intomoby:masterfrom Sep 8, 2023
Merged
integration-cli: Skip TestRmiParentImageFail when using c8d snapshotters#46432thaJeztah merged 1 commit intomoby:masterfrom
thaJeztah merged 1 commit intomoby:masterfrom
Conversation
With containerd image store the images don't depend on each other even if they share the same content and it's totally fine to delete the "parent" image. The skip is necessary because deleting the "parent" image does not produce an error with the c8d image store and deleting the `busybox` image breaks other tests. Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com>
rumpl
approved these changes
Sep 8, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With containerd image store the images don't depend on each other even if they share the same content and it's totally fine to delete the "parent" image.
The skip is necessary because deleting the "parent" image does not produce an error with the c8d image store and deleting the
busyboximage breaks other tests.- What I did
- How I did it
- How to verify it
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)