libnetwork/iptables: fix TestFirewalldInit#46246
Merged
thaJeztah merged 1 commit intomoby:masterfrom Aug 23, 2023
Merged
Conversation
This test didn't make a lot of sense, because `checkRunning()` depends on the `connection` package-var being set, which is done by `firewalldInit()`, so would never be true on its own. Add a small utility that opens its own D-Bus connection to verify if firewalld is running, and otherwise skips the tests (preserving any error in the process). Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
4 tasks
neersighted
approved these changes
Aug 23, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This test didn't make a lot of sense, because
checkRunning()depends on theconnectionpackage-var being set, which is done byfirewalldInit(), so would never be true on its own.Add a small utility that opens its own D-Bus connection to verify if firewalld is running, and otherwise skips the tests (preserving any error in the process).
- A picture of a cute animal (not mandatory but encouraged)