libnetwork/drivers/bridge: setupIPChains(): name output variables#46236
Merged
thaJeztah merged 1 commit intomoby:masterfrom Aug 16, 2023
Merged
libnetwork/drivers/bridge: setupIPChains(): name output variables#46236thaJeztah merged 1 commit intomoby:masterfrom
thaJeztah merged 1 commit intomoby:masterfrom
Conversation
This function has _four_ output variables of the same type, and several defer statements that checked the error returned (but using the `err` variable). This patch names the return variables to make it clearer what's being returned, and renames the error-return to `retErr` to make it clearer where we're dealing with the returned error (and not any local err), to prevent accidentally shadowing. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
akerouanton
approved these changes
Aug 16, 2023
This was referenced Dec 16, 2024
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This function has four output variables of the same type, and several defer statements that checked the error returned (but using the
errvariable).This patch names the return variables to make it clearer what's being returned, and renames the error-return to
retErrto make it clearer where we're dealing with the returned error (and not any local err), to prevent accidentally shadowing.- A picture of a cute animal (not mandatory but encouraged)