client: Client.postHijacked: use Client.buildRequest#45979
Merged
thaJeztah merged 2 commits intomoby:masterfrom Jul 17, 2023
Merged
client: Client.postHijacked: use Client.buildRequest#45979thaJeztah merged 2 commits intomoby:masterfrom
thaJeztah merged 2 commits intomoby:masterfrom
Conversation
Just making my IDE and some linters slightly happier. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Use Client.buildRequest instead of a local copy of the same logic so that we're using the same logic, and there's less chance of diverging. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
rumpl
approved these changes
Jul 17, 2023
vvoland
reviewed
Jul 17, 2023
vvoland
approved these changes
Jul 17, 2023
neersighted
reviewed
Jul 17, 2023
| } | ||
| if resp.StatusCode != http.StatusSwitchingProtocols { | ||
| resp.Body.Close() | ||
| _ = resp.Body.Close() |
Member
There was a problem hiding this comment.
It feels like if we're going to adopt the explicit discarded return paradigm, we should consider re-enabling the relevant linters, so we don't "regress" in the affected files again...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use Client.buildRequest instead of a local copy of the same logic so that we're using the same logic, and there's less chance of diverging.
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)