Fix missing Topology in NodeCSIInfo#45802
Merged
cpuguy83 merged 1 commit intomoby:masterfrom Jun 24, 2023
Merged
Conversation
Added code to correctly retrieve and convert the Topology from the gRPC Swarm Node. Signed-off-by: Drew Erny <derny@mirantis.com>
neersighted
approved these changes
Jun 24, 2023
cpuguy83
approved these changes
Jun 24, 2023
This was referenced Jun 26, 2023
Member
|
Opened backports for 23 and 24; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
- What I did
Added code to
daemon/cluster/convertto include the Topology in the NodeCSIInfo from the gRPC. Apparently in the past, I'd forgotten it.Discovered this in the course of debugging other CSI issues.
- How I did it
A map is a map. Just convert the crap. Please clap.
- How to verify it
I wrote tests because I am a good contributor with attention to detail who does not often misspell "receive".