Skip to content

c8d: ImageService.softImageDelete: use OCI and containerd constants#45609

Merged
thaJeztah merged 2 commits intomoby:masterfrom
thaJeztah:constantly_numb
May 25, 2023
Merged

c8d: ImageService.softImageDelete: use OCI and containerd constants#45609
thaJeztah merged 2 commits intomoby:masterfrom
thaJeztah:constantly_numb

Conversation

@thaJeztah
Copy link
Copy Markdown
Member

relates to #44598 (comment)

- What I did

- How I did it

- How to verify it

- Description for the changelog

- A picture of a cute animal (not mandatory but encouraged)

@thaJeztah thaJeztah added status/2-code-review kind/refactor PR's that refactor, or clean-up code containerd-integration Issues and PRs related to containerd integration labels May 24, 2023
@thaJeztah thaJeztah requested review from cpuguy83 and vvoland May 24, 2023 23:41
thaJeztah added 2 commits May 25, 2023 01:44
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Copy link
Copy Markdown
Member

@laurazard laurazard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thaJeztah thaJeztah added this to the 25.0.0 milestone May 25, 2023
@thaJeztah
Copy link
Copy Markdown
Member Author

thx both! Let me bring this one in

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

containerd-integration Issues and PRs related to containerd integration kind/refactor PR's that refactor, or clean-up code status/2-code-review

Projects

Development

Successfully merging this pull request may close these issues.

3 participants