builder-next: enable OTLP tracing for history records#45579
Merged
thaJeztah merged 1 commit intomoby:masterfrom Jun 20, 2023
Merged
builder-next: enable OTLP tracing for history records#45579thaJeztah merged 1 commit intomoby:masterfrom
thaJeztah merged 1 commit intomoby:masterfrom
Conversation
Member
|
I actually just started a branch this passed week to enable tracing on the HTTP API + OTLP exporters. |
Member
|
discussed with @tonistiigi and this should be ready for review |
Member
|
@tonistiigi looks like there's an issue with the vendor check; |
corhere
reviewed
Jun 1, 2023
Comment on lines
+73
to
+78
| if strings.HasSuffix(info.FullMethod, "opentelemetry.proto.collector.trace.v1.TraceService/Export") { | ||
| return handler(ctx, req) | ||
| } |
Contributor
There was a problem hiding this comment.
Why does this particular gRPC request method need to be special-cased to be excluded from tracing? I'd like to see a code comment with the explanation.
Any reason why the special-casing is done with bespoke code rather than otelgrpc.WithInterceptorFilter?
otelgrpc.WithInterceptorFilter(filters.Not(filters.FullMethodName("/opentelemetry.proto.collector.trace.v1.TraceService/Export")))
Member
There was a problem hiding this comment.
Just discussed in the maintainers call, and it's to prevent an infinite loop (but Tonis will add a comment describing the details)
Member
There was a problem hiding this comment.
(but maybe newer versions of otel can clean this up; he's looking into it)
(don't shoot the messenger)
This enables picking up OTLP tracing context for the gRPC requests. Also sets up the in-memory recorder that BuildKit History API can use to store the traces associated with specific build in a database after build completes. This doesn't enable Jaeger tracing endpoints from env but this can be easily enabled by adding another import if maintainers want it. Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
afae691 to
cfa08f8
Compare
cpuguy83
approved these changes
Jun 16, 2023
corhere
approved these changes
Jun 19, 2023
Member
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This enables picking up OTLP tracing context for the gRPC requests.
Also sets up the in-memory recorder that BuildKit History API can use to store the traces associated with specific build in a database after build completes.
This doesn't enable Jaeger tracing endpoints from env but this can be easily enabled by adding another import if maintainers want it.