Skip to content

removing duplicate ports in docker create parameters#45439

Open
Jeyanthinath wants to merge 2 commits intomoby:masterfrom
Jeyanthinath:duplicate_port_fix
Open

removing duplicate ports in docker create parameters#45439
Jeyanthinath wants to merge 2 commits intomoby:masterfrom
Jeyanthinath:duplicate_port_fix

Conversation

@Jeyanthinath
Copy link
Contributor

Fixes #45199

Created a function, that de-duplicate the port and send a warning message in the api response.

@thaJeztah
Copy link
Member

^ there's a typo in the commit message (parmaeters)

@thaJeztah thaJeztah changed the title removing duplicate ports in docker create parmaeters removing duplicate ports in docker create parameters Apr 30, 2023
@Jeyanthinath Jeyanthinath force-pushed the duplicate_port_fix branch 2 times, most recently from 44369db to 930d6b1 Compare June 18, 2023 11:04
@Jeyanthinath
Copy link
Contributor Author

@thaJeztah can you please validate this PR, only failure test case [docker-py] (might be stuck)

ERROR: failed to solve: process "/bin/sh -c sed -ri \"s/(httpredir|deb).debian.org/${APT_MIRROR:-deb.debian.org}/g\" /etc/apt/sources.list     && sed -ri \"s/(security).debian.org/${APT_MIRROR:-security.debian.org}/g\" /etc/apt/sources.list" did not complete successfully: exit code: 2
Error: The operation was canceled

Signed-off-by: Jeyanthinath Muthuram <jeyanthinath10@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

API should either reject, de-duplicate, or warn duplicate exposed-ports

2 participants