c8d: use the container's configured snapshotter where possible#45274
Merged
thaJeztah merged 1 commit intomoby:masterfrom Apr 5, 2023
Merged
c8d: use the container's configured snapshotter where possible#45274thaJeztah merged 1 commit intomoby:masterfrom
thaJeztah merged 1 commit intomoby:masterfrom
Conversation
While we currently do not provide an option to specify the snapshotter to use for individual containers (we may want to add this option in future), currently it already is possible to configure the snapshotter in the daemon configuration, which could (likely) cause issues when changing and restarting the daemon. This patch updates some code-paths that have the container available to use the snapshotter that's configured for the container (instead of the default snapshotter configured). There are still code-paths to be looked into, and a tracking ticket as well as some TODO's were added for those. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
vvoland
approved these changes
Apr 5, 2023
rumpl
approved these changes
Apr 5, 2023
Member
Author
|
Oh! crap, didn't check if it conflicts with Pawel's PR (hope not) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
docker diff#44964 (comment)While we currently do not provide an option to specify the snapshotter to use for individual containers (we may want to add this option in future), currently it already is possible to configure the snapshotter in the daemon configuration, which could (likely) cause issues when changing and restarting the daemon.
This patch updates some code-paths that have the container available to use the snapshotter that's configured for the container (instead of the default snapshotter configured).
There are still code-paths to be looked into, and a tracking ticket as well as some TODO's were added for those.
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)