Skip to content

[don't merge] ci: enable TEST_INTEGRATION_USE_SNAPSHOTTER#45232

Closed
vvoland wants to merge 4 commits intomoby:masterfrom
vvoland:c8d-ci
Closed

[don't merge] ci: enable TEST_INTEGRATION_USE_SNAPSHOTTER#45232
vvoland wants to merge 4 commits intomoby:masterfrom
vvoland:c8d-ci

Conversation

@vvoland
Copy link
Contributor

@vvoland vvoland commented Mar 30, 2023

A draft PR to have the CI run integration tests with containerd integration enabled.

@vvoland vvoland added area/testing containerd-integration Issues and PRs related to containerd integration labels Mar 30, 2023
@thaJeztah
Copy link
Member

@vvoland I did a quick rebase of this branch to get a fresh run of CI

@thaJeztah thaJeztah force-pushed the c8d-ci branch 6 times, most recently from a06482c to e83ea1b Compare April 14, 2023 12:18
@thaJeztah
Copy link
Member

/cc @laurazard @rumpl

@thaJeztah
Copy link
Member

Seeing a lot of these failures; looks like something with restoring the frozen images? Haven't checked

TestDockerRegistryAuthHtpasswdSuite/TestLogoutWithExternalAuth
    docker_cli_logout_test.go:16: assertion failed: error is not nil: Error response from daemon: No such image: busybox:latest: [d5193e4374e5c] failed to download busybox
    --- FAIL: TestDockerRegistryAuthHtpasswdSuite/TestLogoutWithExternalAuth (0.67s)

vvoland and others added 4 commits October 16, 2023 12:51
Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com>
Add a function to return tags for the given repository reference. This
is needed to implement the `pull -a` (pull all tags) for containerd
which doesn't directly use distribution, but we need to somehow make an
API call to the registry to obtain the available tags.

Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com>
Use the distribution code to query the remote repository for tags and
pull them sequentially just like the non-c8d pull.

Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com>
@rumpl
Copy link
Member

rumpl commented Oct 16, 2023

Woop woop, we can close this now!!!!

@vvoland
Copy link
Contributor Author

vvoland commented Oct 16, 2023

🎉

@vvoland vvoland closed this Oct 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/testing containerd-integration Issues and PRs related to containerd integration

Projects

Development

Successfully merging this pull request may close these issues.

3 participants