libcontainerd: Upgrade to typeurl/v2#45094
Merged
vvoland merged 1 commit intomoby:masterfrom Mar 8, 2023
Merged
Conversation
corhere
approved these changes
Mar 1, 2023
rumpl
approved these changes
Mar 2, 2023
In preparation for containerd v1.7 which migrates off gogo/protobuf and changes the protobuf Any type to one that's not supported by our vendored version of typeurl. This fixes a compile error on usages of `typeurl.UnmarshalAny` when upgrading to containerd v1.7. Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com>
AkihiroSuda
approved these changes
Mar 8, 2023
Contributor
Author
|
CI is happy, I will go ahead and merge this one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Preemptively upgrade the typeurl to v2, to avoid compilation errors once we upgrade to containerd v1.7.
v1.7 migrated off
gogo/protobufand changed the protobuf Any to one that's not supported by the vendoredtypeurl.UnmarshalAny, which is used for example here:moby/libcontainerd/remote/client.go
Line 332 in 7aa3671
- What I did
- How I did it
- How to verify it
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)