Skip to content

c8d/list: Support dangling filter#45092

Merged
thaJeztah merged 1 commit intomoby:masterfrom
vvoland:c8d-dangling-filter-upstream
Mar 6, 2023
Merged

c8d/list: Support dangling filter#45092
thaJeztah merged 1 commit intomoby:masterfrom
vvoland:c8d-dangling-filter-upstream

Conversation

@vvoland
Copy link
Contributor

@vvoland vvoland commented Mar 1, 2023 •
edited
Loading

- What I did
Implemented dangling filter for c8d image store

- How I did it

- How to verify it

$ docker images
REPOSITORY   TAG       IMAGE ID       CREATED          SIZE
myimage      latest    69665d02cb32   1 second ago     3.27MB
<none>       <none>    7b3ccabffc97   1 second ago     2.01MB

$ docker images -f 'dangling=true'
REPOSITORY   TAG       IMAGE ID       CREATED         SIZE
<none>       <none>    7b3ccabffc97   6 seconds ago   2.01MB

$ docker images -f 'dangling=false'
REPOSITORY   TAG       IMAGE ID       CREATED          SIZE
myimage      latest    69665d02cb32   8 seconds ago    3.27MB

- Description for the changelog

- A picture of a cute animal (not mandatory but encouraged)

@vvoland vvoland added area/images Image Distribution containerd-integration Issues and PRs related to containerd integration labels Mar 1, 2023
@thaJeztah
Copy link
Member

thaJeztah commented Mar 3, 2023

doh! needs a rebase, @vvoland

@thaJeztah thaJeztah added this to the v-next milestone Mar 3, 2023
thaJeztah
thaJeztah approved these changes Mar 3, 2023
View reviewed changes
Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes LGTM after rebase

@vvoland
c8d/list: Support dangling filter
c477cda 
Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com>
@vvoland vvoland force-pushed the c8d-dangling-filter-upstream branch from f78bfa1 to c477cda Compare March 3, 2023 15:26
@vvoland
Copy link
Contributor Author

vvoland commented Mar 3, 2023 •
edited
Loading

Ugh, rebased. Wish there was a notification when a PR starts having conflicts 😶‍🌫️

@thaJeztah
Copy link
Member

thaJeztah commented Mar 3, 2023

Yeah, the "re-re-re-rebase-bot" from my wishlist

@thaJeztah
Copy link
Member

thaJeztah commented Mar 6, 2023

CI is still happy; bringing this one in 👍

@thaJeztah thaJeztah merged commit 17f17c2 into moby:master Mar 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rumpl rumpl rumpl approved these changes

@thaJeztah thaJeztah thaJeztah approved these changes

Assignees

No one assigned

Labels

area/images Image Distribution containerd-integration Issues and PRs related to containerd integration status/2-code-review

Projects

containerd integration
Status: Done

Milestone

24.0.0

Development

Successfully merging this pull request may close these issues.

containerd integration: implement "dangling" filter for images

3 participants

@vvoland @thaJeztah @rumpl