[23.0 backport] client: improve error messaging on crash#44883
Merged
[23.0 backport] client: improve error messaging on crash#44883
Conversation
Repro steps: - Run Docker Desktop - Run `docker run busybox tail -f /dev/null` - Run `pkill "Docker Desktop" Expected: An error message that indicates that Docker Desktop is shutting down. Actual: An error message that looks like this: ``` error waiting for container: invalid character 's' looking for beginning of value ``` here's an example: docker/for-mac#6575 (comment) After this change, you get an error message like: ``` error waiting for container: copying response body from Docker: unexpected EOF ``` which is a bit more explicit. Signed-off-by: Nick Santos <nick.santos@docker.com> (cherry picked from commit 9900c7a) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
AkihiroSuda
approved these changes
Jan 30, 2023
vvoland
approved these changes
Jan 31, 2023
Member
Author
|
Let me bring this one in 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Repro steps:
docker run busybox tail -f /dev/nullExpected:
An error message that indicates that Docker Desktop is shutting down.
Actual:
An error message that looks like this:
here's an example:
docker/for-mac#6575 (comment)
After this change, you get an error message like:
which is a bit more explicit.
(cherry picked from commit 9900c7a)
- What I did
- How I did it
- How to verify it
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)