Updated outdated docker contributing guidelines link#44744
Merged
neersighted merged 1 commit intoJan 5, 2023
Conversation
Signed-off-by: Kirk Easterson <kirk.easterson@gmail.com>
Contributor
Author
|
There are at least 5 other broken links in this document. Anything starting with 'docs.docker.com/opensource' is a broken link. I don't know what the equivalent links are, but it may require a rewrite of some guidelines if the equivalent link no longer exists. I haven't spent too much time on that though. This PR only concerns the one link that I found. |
neersighted
approved these changes
Jan 5, 2023
neersighted
left a comment
Member
There was a problem hiding this comment.
The docs situation is not great and will require some concerted work from both the Docker folks and contributors to the Moby repo, but we shouldn't let that hold us back from cleaning up the low hanging fruit. Thanks!
This was referenced Jan 15, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
- What I did Updated the contributing guidelines link. I discovered this when making a separate PR.
- How I did it Found the equivalent link for docker contributing guidelines
- How to verify it Click the link
- Description for the changelog
Updated contributing guidelines link in
CONTRIBUTING.mdsince the old link was broken.- A picture of a cute animal (not mandatory but encouraged)