Skip to content

logger: remove logentries driver#44442

Closed
neersighted wants to merge 1 commit intomoby:masterfrom
neersighted:logentries_removal
Closed

logger: remove logentries driver#44442
neersighted wants to merge 1 commit intomoby:masterfrom
neersighted:logentries_removal

Conversation

@neersighted
Copy link
Member

@neersighted neersighted commented Nov 10, 2022

- What I did
Remove the Logentries (SaaS) log driver from the project, as the service will be discontinued on November 15, 2022:

Dear Logentries user,

We have identified you as the owner of, or collaborator of, a Logentries account.

The Logentries service will be discontinued on November 15th, 2022. This means that your Logentries account access will be removed and all your log data will be permanently deleted on this date.

Next Steps
If you are interested in an alternative Rapid7 log management solution, InsightOps will be available for purchase through December 16th, 2022. Please note, there is no support to migrate your existing Logentries account to InsightOps.

Thank you for being a valued user of Logentries.

Thank you,
Rapid7 Customer Success

- How I did it
🔥

- How to verify it
CI 🟢

- Description for the changelog
Remove the Logentries logdriver as the service has been shut down.

- A picture of a cute animal (not mandatory but encouraged)
Fat Rat

The Logentries service will be discontinued next week:

> Dear Logentries user,
>
> We have identified you as the owner of, or collaborator of, a Logentries account.
>
> The Logentries service will be discontinued on November 15th, 2022. This means that your Logentries account access will be removed and all your log data will be permanently deleted on this date.
>
> Next Steps
> If you are interested in an alternative Rapid7 log management solution, InsightOps will be available for purchase through December 16th, 2022. Please note, there is no support to migrate your existing Logentries account to InsightOps.
>
> Thank you for being a valued user of Logentries.
>
> Thank you,
> Rapid7 Customer Success

There is no reason to preserve this code in Moby as a result.

Signed-off-by: Bjorn Neergaard <bneergaard@mirantis.com>
@thaJeztah
Copy link
Member

Oh! I forgot about this one (may actually have started a branch for this that I didn't complete)

Some things we should look at;

  • Either migrate existing containers during start (restore), so that existing containers continue to function; we could switch them to use the default (jsonfile)
  • And/or make logentries an alias for jsonfile (but we need to check where we can alias and where we can produce an error)

Basically, when creating a new container, ideally, we'd produce an error that the logging driver is deprecated (I guess currently it produces a "no such driver", which may be ok, but perhaps (at least temporary) have a more informative error would be good.

For existing containers, automatically switch over to a still supported driver. If we alias, we could do so without modifying state of the containers, but perhaps "migrate" is the better option, as even when downgrading to an older version of the engine, the service won't work.

@thaJeztah thaJeztah added this to the v-next milestone Nov 10, 2022
@neersighted
Copy link
Member Author

👍, a graceful migration seems at least worth exploring; I'll do so in this PR.

@AkihiroSuda
Copy link
Member

Needs rebase

Remove the Logentries (SaaS) log driver from the project, as the service will be discontinued on November 15, 2022.

Is there a source about this?
Can't find the information on https://logentries.com/ .
(Most links there are already 404 though)

@neersighted
Copy link
Member Author

I need to rebase this yes, but I also need to see about adding some graceful migration code to move restored containers to the current default driver (discussed in a past maintainer's call).

As to Rapid7 discontinuing the Logentries SaaS product, see the commit message for the email I was sent, as a user.

@thaJeztah
Copy link
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants