daemon: split image search to a separate service#44032
Draft
thaJeztah wants to merge 5 commits intomoby:masterfrom
Draft
daemon: split image search to a separate service#44032thaJeztah wants to merge 5 commits intomoby:masterfrom
thaJeztah wants to merge 5 commits intomoby:masterfrom
Conversation
57aacfc to
74ae853
Compare
thaJeztah
commented
Aug 25, 2022
api/server/router/image/image.go
Outdated
Comment on lines
+20
to
+24
| func NewRouter(backend Backend, referenceBackend reference.Store, imageStore image.Store, layerStore layer.Store) router.Router { | ||
| func NewRouter(backend Backend, searchBackend SearchBackend, referenceBackend reference.Store, imageStore image.Store, layerStore layer.Store) router.Router { | ||
| ir := &imageRouter{ | ||
| backend: backend, | ||
| searchBackend: searchBackend, |
Member
Author
There was a problem hiding this comment.
FWIW; perhaps this should be a separate router, but we can do so in a follow-up. I kept it here, as the endpoint is still /images/search, so it felt like for the "router" it still made sense to have it here
Member
Author
|
Ah, dang; forgot to GoDoc this one |
74ae853 to
9192fdb
Compare
corhere
requested changes
Aug 25, 2022
Contributor
corhere
left a comment
There was a problem hiding this comment.
The registry config is reloadable so any config updates need to also be propagated into SearchService. (And despite being synchronized with a mutex, the config reload is not atomic! 🤦) Perhaps introduce a "registry config store" which holds the config and is passed into both registry services? E.g.:
package registry
type ConfigStore struct {
v atomic.Value // or go1.19 atomic.Pointer[serviceConfig]
}
func (s ConfigStore) get() *serviceConfig {
p := s.v.Load()
if p == nil {
return emptyServiceConfig
}
return p.(*serviceConfig)
}
func (s ConfigStore) Set(opts ServiceOptions) error {
cfg, err := newServiceConfig(opts)
if err != nil {
return err
}
s.v.Store(cfg)
return nil
}
Member
Author
|
Ah, good one; I didn't think of reloading "insecure registries" (does it use mirrors?) for this one. 🤔 |
9192fdb to
7689955
Compare
Moves the TestPingRegistryEndpoint and TestEndpoint tests. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Also touching-up some comments. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
This extracts the image search to its own service, as searching a registry for images does not depend on functionality of the image service. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
There's only a single implementation, so no need to return an interface. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
7689955 to
22e3724
Compare
Member
Author
Oh, sorry, yes, I only did a rebase to prevent it fully bit-rotting; need to reserve some time to find the best approach for the config reloading part. Ignore for now, I'll give a ping when I found time for that 😅 |
This was referenced Aug 29, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This extracts the image search to its own service, as searching a registry for images does not depend on functionality of the image service.
See individual commits for details.