testing: update docker-py 6.1.3 #43998

thaJeztah · 2022-08-19T18:35:02Z

🤞 hope this is gonna work, because the CLI inside the container is 17.06, and docker/docker-py@cd2c35a changed the Dockerfile we build to depend on BuildKit features (--mount)

depends on Dockerfile: Use separate cli for shell and integration-cli #45358
depends on testing: temporarily pin docker-py tests to use "bullseye" #45769

testing: update docker-py 6.0.1

release notes: https://github.com/docker/docker-py/releases/tag/6.0.1

full diff: docker/docker-py@5.0.3...6.0.1

testing: update docker-py 6.1.3

full diff: docker/docker-py@6.0.1...6.1.3

- A picture of a cute animal (not mandatory but encouraged)

thaJeztah · 2022-08-19T19:52:12Z

Yup, this won't work;

[2022-08-19T18:48:46.377Z] Removing intermediate container d740ccf379b1
[2022-08-19T18:48:46.377Z]  ---> 8e295f18f46e
[2022-08-19T18:48:46.377Z] Step 18/24 : COPY requirements.txt /src/requirements.txt
[2022-08-19T18:48:46.377Z]  ---> d8982936ed2c
[2022-08-19T18:48:46.377Z] Step 19/24 : RUN --mount=type=cache,target=/root/.cache/pip     pip install -r requirements.txt
[2022-08-19T18:48:46.377Z] the --mount option requires BuildKit. Refer to https://docs.docker.com/go/buildkit/ to learn how to build images with BuildKit enabled

Perhaps it's time to move the docker-py tests outside of docker-in-docker (perhaps even run them on github actions if we already have code there to spin up the docker daemon)

thaJeztah · 2022-10-03T21:26:12Z

building the docker-py image now happens on GitHub actions, so moving this out of draft 👍

thaJeztah · 2022-10-04T08:23:42Z

building the docker-py image now happens on GitHub actions, so moving this out of draft 👍

Ah, sorry, I was wrong; while it moved to GitHub actions, we're still building the image docker-in-docker, using the classic builder;

make -o build test-docker-py
...
---> Running in 8b073cc8873c
Removing intermediate container 8b073cc8873c
 ---> 64c612d46f69
Step 18/24 : COPY requirements.txt /src/requirements.txt
 ---> 06e121a60a1a
Step 19/24 : RUN --mount=type=cache,target=/root/.cache/pip     pip install -r requirements.txt
the --mount option requires BuildKit. Refer to https://docs.docker.com/go/buildkit/ to learn how to build images with BuildKit enabled
Error: The operation was canceled.

So still some work needed there

thaJeztah · 2023-06-20T13:26:41Z

1 Failure (and some XFAIL, but those can probably be ignored)

=================================== FAILURES ===================================
___________ AttachContainerTest.test_run_container_reading_socket_ws ___________
tests/integration/api_container_test.py:1245: in test_run_container_reading_socket_ws
    pty_stdout = self.client.attach_socket(container, opts, ws=True)
docker/utils/decorators.py:19: in wrapped
    return f(self, resource_id, *args, **kwargs)
docker/api/container.py:98: in attach_socket
    return self._attach_websocket(container, params)
docker/utils/decorators.py:19: in wrapped
    return f(self, resource_id, *args, **kwargs)
docker/api/client.py:312: in _attach_websocket
    return self._create_websocket_connection(full_url)
docker/api/client.py:315: in _create_websocket_connection
    return websocket.create_connection(url)
/usr/local/lib/python3.7/site-packages/websocket/_core.py:601: in create_connection
    websock.connect(url, **options)
/usr/local/lib/python3.7/site-packages/websocket/_core.py:245: in connect
    options.pop('socket', None))
/usr/local/lib/python3.7/site-packages/websocket/_http.py:117: in connect
    hostname, port, resource, is_secure = parse_url(url)
/usr/local/lib/python3.7/site-packages/websocket/_url.py:62: in parse_url
    raise ValueError("scheme %s is invalid" % scheme)
E   ValueError: scheme http+docker is invalid
------- generated xml file: /src/bundles/test-docker-py/junit-report.xml -------
=========================== short test summary info ============================
XFAIL tests/integration/api_container_test.py::CreateContainerTest::test_create_with_cpu_rt_options
  CONFIG_RT_GROUP_SCHED isn't enabled
XFAIL tests/integration/api_container_test.py::CreateContainerTest::test_create_with_storage_opt
  Not supported on most drivers
XFAIL tests/integration/api_container_test.py::ContainerTopTest::test_top
  Output of docker top depends on host distro, and is not formalized.
XFAIL tests/integration/api_container_test.py::ContainerTopTest::test_top_with_psargs
  Output of docker top depends on host distro, and is not formalized.
XFAIL tests/integration/api_swarm_test.py::SwarmTest::test_init_swarm_data_path_addr
  Can fail if eth0 has multiple IP addresses
XFAIL tests/integration/api_swarm_test.py::SwarmTest::test_init_swarm_with_log_driver
  This doesn't seem to be taken into account by the engine
SKIPPED [1] tests/integration/api_image_test.py:291: Doesn't work inside a container - FIXME
SKIPPED [1] tests/integration/api_swarm_test.py:30: Test stalls the engine on 1.12.0
= 1 failed, 391 passed, 2 skipped, 1 deselected, 6 xfailed, 3 xpassed in 248.00s (0:04:08) =
sys:1: ResourceWarning: unclosed <socket.socket fd=11, family=AddressFamily.AF_UNIX, type=SocketKind.SOCK_STREAM, proto=0, raddr=/go/src/github.com/docker/docker/bundles/test-docker-py/docker.sock>
sys:1: ResourceWarning: unclosed <socket.socket fd=12, family=AddressFamily.AF_UNIX, type=SocketKind.SOCK_STREAM, proto=0, raddr=/go/src/github.com/docker/docker/bundles/test-docker-py/docker.sock>
sys:1: ResourceWarning: unclosed <socket.socket fd=13, family=AddressFamily.AF_UNIX, type=SocketKind.SOCK_STREAM, proto=0, raddr=/go/src/github.com/docker/docker/bundles/test-docker-py/docker.sock>
sys:1: ResourceWarning: unclosed <socket.socket fd=14, family=AddressFamily.AF_UNIX, type=SocketKind.SOCK_STREAM, proto=0, raddr=/go/src/github.com/docker/docker/bundles/test-docker-py/docker.sock>
sys:1: ResourceWarning: unclosed <socket.socket fd=15, family=AddressFamily.AF_UNIX, type=SocketKind.SOCK_STREAM, proto=0, raddr=/go/src/github.com/docker/docker/bundles/test-docker-py/docker.sock>
sys:1: ResourceWarning: unclosed <socket.socket fd=16, family=AddressFamily.AF_UNIX, type=SocketKind.SOCK_STREAM, proto=0, raddr=/go/src/github.com/docker/docker/bundles/test-docker-py/docker.sock>
Error: The operation was canceled.

thaJeztah · 2023-08-29T12:18:22Z

Remaining skips need a new release of docker-py;

TODO re-enable test_attach_no_stream after Flaky test: AttachContainerTest.test_attach_no_stream docker/docker-py#2513 is resolved
TODO re-enable test_create_with_restart_policy after tests/integration: update some tests for updated error-messages docker/docker-py#3165 is included in a release
TODO re-enable test_api_error_parses_json after tests/integration: update some tests for updated error-messages docker/docker-py#3165 is included in a release
TODO re-enable test_connect_with_ipv6_address after we updated to a version of docker-py with integration: Fix bad subnet declaration docker/docker-py#3169
TODO re-enable test_create_network_ipv6_enabled after we updated to a version of docker-py with integration: Fix bad subnet declaration docker/docker-py#3169
TODO re-enable test_create_with_ipv6_address after we updated to a version of docker-py with integration: Fix bad subnet declaration docker/docker-py#3169

thaJeztah · 2023-08-29T15:28:03Z

Right, so that one failure continues:

___________ AttachContainerTest.test_run_container_reading_socket_ws ___________
tests/integration/api_container_test.py:1245: in test_run_container_reading_socket_ws
    pty_stdout = self.client.attach_socket(container, opts, ws=True)
docker/utils/decorators.py:19: in wrapped
    return f(self, resource_id, *args, **kwargs)
docker/api/container.py:98: in attach_socket
    return self._attach_websocket(container, params)
docker/utils/decorators.py:19: in wrapped
    return f(self, resource_id, *args, **kwargs)
docker/api/client.py:312: in _attach_websocket
    return self._create_websocket_connection(full_url)
docker/api/client.py:315: in _create_websocket_connection
    return websocket.create_connection(url)
/usr/local/lib/python3.7/site-packages/websocket/_core.py:601: in create_connection
    websock.connect(url, **options)
/usr/local/lib/python3.7/site-packages/websocket/_core.py:245: in connect
    options.pop('socket', None))
/usr/local/lib/python3.7/site-packages/websocket/_http.py:117: in connect
    hostname, port, resource, is_secure = parse_url(url)
/usr/local/lib/python3.7/site-packages/websocket/_url.py:62: in parse_url
    raise ValueError("scheme %s is invalid" % scheme)
E   ValueError: scheme http+docker is invalid
------- generated xml file: /src/bundles/test-docker-py/junit-report.xml -------

Hm, right, so error is:

E   ValueError: scheme http+docker is invalid

looks like there's a ticket in docker-py; "{ValueError} scheme http+docker is invalid" raised when attaching WebSocket docker/docker-py#1478. Let's skip the test for now

Our dev-container now has buildx installed, so we're no longer limited to 17.06. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>

release notes: https://github.com/docker/docker-py/releases/tag/6.0.1 full diff: docker/docker-py@5.0.3...6.0.1 Signed-off-by: Sebastiaan van Stijn <github@gone.nl>

…socket_ws Tests are failing with this error: E ValueError: scheme http+docker is invalid Which is reported in docker-py in docker/docker-py#1478. Not sure what changed in the tests, but could be due to updated Python version or dependencies, but let's skip it for now. Test failure: ___________ AttachContainerTest.test_run_container_reading_socket_ws ___________ tests/integration/api_container_test.py:1245: in test_run_container_reading_socket_ws pty_stdout = self.client.attach_socket(container, opts, ws=True) docker/utils/decorators.py:19: in wrapped return f(self, resource_id, *args, **kwargs) docker/api/container.py:98: in attach_socket return self._attach_websocket(container, params) docker/utils/decorators.py:19: in wrapped return f(self, resource_id, *args, **kwargs) docker/api/client.py:312: in _attach_websocket return self._create_websocket_connection(full_url) docker/api/client.py:315: in _create_websocket_connection return websocket.create_connection(url) /usr/local/lib/python3.7/site-packages/websocket/_core.py:601: in create_connection websock.connect(url, **options) /usr/local/lib/python3.7/site-packages/websocket/_core.py:245: in connect options.pop('socket', None)) /usr/local/lib/python3.7/site-packages/websocket/_http.py:117: in connect hostname, port, resource, is_secure = parse_url(url) /usr/local/lib/python3.7/site-packages/websocket/_url.py:62: in parse_url raise ValueError("scheme %s is invalid" % scheme) E ValueError: scheme http+docker is invalid ------- generated xml file: /src/bundles/test-docker-py/junit-report.xml ------- Signed-off-by: Sebastiaan van Stijn <github@gone.nl>

full diff: docker/docker-py@6.0.1...6.1.3 Signed-off-by: Sebastiaan van Stijn <github@gone.nl>

thaJeztah · 2023-08-29T16:43:33Z

Itsa greeeeeen ✅ ✅ ✅

thaJeztah added status/2-code-review area/testing process/cherry-pick labels Aug 19, 2022

thaJeztah added this to the v-next milestone Aug 19, 2022

thaJeztah force-pushed the docker_py_6 branch from 39c4263 to ca7786d Compare October 3, 2022 21:24

thaJeztah marked this pull request as ready for review October 3, 2022 21:25

thaJeztah requested a review from tianon as a code owner October 3, 2022 21:25

thaJeztah mentioned this pull request Oct 3, 2022

Volume prune: only prune anonymous volumes by default #44216

Merged

neersighted approved these changes Oct 3, 2022

View reviewed changes

rumpl modified the milestones: 24.0.0, v-future Apr 24, 2023

thaJeztah changed the title ~~testing: update docker-py 6.0.0~~ testing: update docker-py 6.1.3 Jun 20, 2023

thaJeztah force-pushed the docker_py_6 branch 2 times, most recently from 6b45532 to 803789c Compare June 20, 2023 09:52

thaJeztah force-pushed the docker_py_6 branch from 803789c to 8be2bf4 Compare July 29, 2023 20:03

thaJeztah force-pushed the docker_py_6 branch from 8be2bf4 to a89c07c Compare August 29, 2023 12:15

thaJeztah added area/ux and removed area/ux labels Aug 29, 2023

thaJeztah force-pushed the docker_py_6 branch from a89c07c to 3f92711 Compare August 29, 2023 15:28

thaJeztah added 4 commits August 29, 2023 17:29

test-docker-py: remove comment about docker 17.06 limitations

79a0f82

Our dev-container now has buildx installed, so we're no longer limited to 17.06. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>

testing: update docker-py 6.0.1

e0f171f

release notes: https://github.com/docker/docker-py/releases/tag/6.0.1 full diff: docker/docker-py@5.0.3...6.0.1 Signed-off-by: Sebastiaan van Stijn <github@gone.nl>

testing: update docker-py 6.1.3

a9a0ffa

full diff: docker/docker-py@6.0.1...6.1.3 Signed-off-by: Sebastiaan van Stijn <github@gone.nl>

thaJeztah force-pushed the docker_py_6 branch from 3f92711 to a9a0ffa Compare August 29, 2023 15:32

thaJeztah modified the milestones: v-future, 25.0.0 Aug 29, 2023

thaJeztah merged commit 9af5484 into moby:master Aug 29, 2023

thaJeztah deleted the docker_py_6 branch August 29, 2023 20:59

thaJeztah mentioned this pull request Aug 29, 2023

testing: update docker-py to 7.0.0b1 #46368

Merged

thaJeztah mentioned this pull request Jan 17, 2024

[24.0 backport] testing: update docker-py to 7.0.0 #47098

Merged

thaJeztah added process/cherry-picked and removed process/cherry-pick labels Jan 17, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

testing: update docker-py 6.1.3 #43998

testing: update docker-py 6.1.3 #43998

Uh oh!

thaJeztah commented Aug 19, 2022 •

edited

Loading

Uh oh!

thaJeztah commented Aug 19, 2022

Uh oh!

thaJeztah commented Oct 3, 2022

Uh oh!

thaJeztah commented Oct 4, 2022

Uh oh!

thaJeztah commented Jun 20, 2023

Uh oh!

thaJeztah commented Aug 29, 2023

Uh oh!

thaJeztah commented Aug 29, 2023

Uh oh!

thaJeztah commented Aug 29, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

testing: update docker-py 6.1.3 #43998

testing: update docker-py 6.1.3 #43998

Uh oh!

Conversation

thaJeztah commented Aug 19, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

testing: update docker-py 6.0.1

testing: update docker-py 6.1.3

Uh oh!

thaJeztah commented Aug 19, 2022

Uh oh!

thaJeztah commented Oct 3, 2022

Uh oh!

thaJeztah commented Oct 4, 2022

Uh oh!

thaJeztah commented Jun 20, 2023

Uh oh!

thaJeztah commented Aug 29, 2023

Uh oh!

thaJeztah commented Aug 29, 2023

Uh oh!

thaJeztah commented Aug 29, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

thaJeztah commented Aug 19, 2022 •

edited

Loading