-
Notifications
You must be signed in to change notification settings - Fork 18.9k
containerd integration: imageservice: add contexts to various methods #43828
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
364637d to
f762cb8
Compare
|
Looks like something is hanging after the tests completed. I opened #43832 to remove the first commit from this PR to make the diff smaller. |
f762cb8 to
55cac38
Compare
|
Looks like something's wrong with this change, but only seeing it in the tests running in Jenkins. Tests complete succesfully ( |
55cac38 to
bc641c6
Compare
|
Looks like we have one integration test "pass" and all the other ones hung; I'm gonna do a revert of the last commit to try if that makes a change, as I seem to recall it was green at some point before I made that change (but no clue how it would make a difference) |
bc641c6 to
9c2197f
Compare
|
nope; that didn't help (didn't really expect it would, but worth trying, just in case) |
8ae85d0 to
e448c82
Compare
b3acd9a to
f460ccf
Compare
|
Still hanging; looks like tests complete, but it fails to tear down things (perhaps containers that are kept running?) Downloaded the "rootless" bundles, and there's at least some tests that contain container logs (which COULD be an indication that those containers weren't cleaned up when the test completed); DetailsAnd for arm64-integration bundles; Details |
f460ccf to
3478507
Compare
3478507 to
527217a
Compare
In preparation of adding support for image inspect. Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com> Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
527217a to
b1d50a6
Compare

In preparation of adding support for image inspect.
- A picture of a cute animal (not mandatory but encouraged)