api: deprecate BuildCache.Parent, add BuildCache.Parents in API >= v1.42#43631
Merged
thaJeztah merged 6 commits intomoby:masterfrom Aug 4, 2022
Merged
api: deprecate BuildCache.Parent, add BuildCache.Parents in API >= v1.42#43631thaJeztah merged 6 commits intomoby:masterfrom
thaJeztah merged 6 commits intomoby:masterfrom
Conversation
Member
Author
|
@crazy-max @tonistiigi PTAL |
90dbc2f to
6576d5b
Compare
tianon
approved these changes
May 23, 2022
Member
Author
|
Having some discussion on Slack; looks like the replacement is a Parents (plural) field, so we may have to add that one as well |
6576d5b to
c62be91
Compare
c62be91 to
3010aa4
Compare
Member
Author
I added the @tianon @tonistiigi @crazy-max PTAL |
Member
|
SGTM thanks! |
tonistiigi
reviewed
Aug 3, 2022
docs/api/version-history.md
Outdated
| * The `BuildCache.Parent` field, as returned by `GET /system/df` is deprecated | ||
| and is now omitted. API versions before v1.42 continue to include this field. | ||
| * `GET /system/df` now includes a new `Parents` field, for "build-cache" records, | ||
| which contains a list of parent ID's for the build-cache record. |
Member
Author
There was a problem hiding this comment.
Yes, I think you're right; must've been in "dutch" mode while I wrote this 🇳🇱 😁
tonistiigi
approved these changes
Aug 3, 2022
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
This field has been deprecated in BuildKit, so this follows the deprecation in the Engine API. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
This field was added to replace the deprecated "Parent" field. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
3010aa4 to
43956c1
Compare
Member
Author
|
Failure on Windwos 2022 is unrelated, but let me post this as I've seen this error pop-up a few times (could be a platform issue) |
Member
Author
|
All green now 👍 |
Member
Author
This was referenced Oct 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First two commits are documenting the fields
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)