Dockerfile: move installers into Dockerfile, and update registry versions#42881
Merged
AkihiroSuda merged 2 commits intomoby:masterfrom Sep 27, 2021
Merged
Dockerfile: move installers into Dockerfile, and update registry versions#42881AkihiroSuda merged 2 commits intomoby:masterfrom
AkihiroSuda merged 2 commits intomoby:masterfrom
Conversation
This moves installers that are only used during CI into the Dockerfile. Some installers are still used in the release-pipeline, so keeping thos for now. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
- using v2.1.0 for the "v1" registry (last release with only v1) - using v2.3.0 as "current" version (was v2.3.0-rc.0) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
58d82aa to
ce71550
Compare
Member
Author
Thanks! I took some of that from #40094, which was an old attempt to do something like this (some follow-ups are still needed to "punch through" all options to the build, but I need to have a closer look at some of those to take into account both the |
Member
Author
|
@AkihiroSuda @cpuguy83 PTAL |
AkihiroSuda
approved these changes
Sep 27, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #42674
This moves installers that are only used during CI into the Dockerfile. Some installers are still used in the release-pipeline, so keeping thos for now.
Looks like various tests are failing on registry v2.7.1, so I'm keeping further updates for a follow-up to be looked into
- A picture of a cute animal (not mandatory but encouraged)