api: add const for 'X-Registry-Auth'#42790
Conversation
7ea9c56 to
7ebe3ff
Compare
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
7ebe3ff to
5ef7f0b
Compare
|
I'm not entirely convinced on this one -- I get that it's conceptually cleaner, but the end result is longer everywhere? 😬 😩 (and the likelihood of changing the value is slim to none) (Probably just being overly superficial here -- I'm definitely not going to be a blocker on this. 🙈) |
|
I'm not super strongly attached to this. My train of thought was that this is not a standard header (we defined it as part of our API). From that perspective, I felt it would be useful to have a Truth is that this started out with me digging into some of the authentication bits, and finding myself repeatedly |
|
Ahhh, that's fair enough; I'm convinced. 😅
|
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)