daemon: cleanupContainer(): pass ContainerRmConfig as parameter#42774
Closed
thaJeztah wants to merge 2 commits intomoby:masterfrom
Closed
daemon: cleanupContainer(): pass ContainerRmConfig as parameter#42774thaJeztah wants to merge 2 commits intomoby:masterfrom
thaJeztah wants to merge 2 commits intomoby:masterfrom
Conversation
Renamed a variable that collided with an import. Also remove the named return variable from cleanupContainer(), as it wasn't used. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
We already have this config, so might as well pass it, instead of passing each option as a separate argument. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
2bf37e0 to
5125ab8
Compare
Member
Author
|
@AkihiroSuda @tianon ptal 😅 |
tianon
approved these changes
Aug 23, 2021
Member
Author
|
closing in favour of #43206, which includes this |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We already have this config, so might as well pass it, instead of passing each option as a separate argument.
First commit fixes some variable names that clashed with imports
- How to verify it
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)