api/types/events: add "Type" type for event-type enum #42770
Merged
+25
−32
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
245f96d to
d2234ae
Compare
tianon
approved these changes
Aug 23, 2021
thaJeztah
commented
Aug 23, 2021
api/types/events/events.go
Outdated
Comment on lines
15
to
18
Member
Author
There was a problem hiding this comment.
Hm... I should've sorted this list while I was changing this.
Let me get that sorted (pun intended) before we merge this 😅
Currently just an alias for string, but we can change it to be an actual type. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
d2234ae to
247f479
Compare
Member
Author
|
Sorted! Hope the Jenkins gods shine on me, and that CI will be green again (not hitting a flaky) 🤗 |
tianon
approved these changes
Aug 23, 2021
Member
Author
|
@AkihiroSuda ptal |
AkihiroSuda
approved these changes
Aug 27, 2021
1 task
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently just an alias for string, but we can change it to be an actual type.
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)