Merged
Conversation
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
b5beee4 to
13cb04e
Compare
Member
Author
thaJeztah
commented
Jul 27, 2021
| // DefaultLinuxSpec create a default spec for running Linux containers | ||
| func DefaultLinuxSpec() specs.Spec { | ||
| s := specs.Spec{ | ||
| return specs.Spec{ |
Member
Author
There was a problem hiding this comment.
Changes in this file are easiest reviewed with "ignore whitespace"; https://github.com/moby/moby/pull/42683/files?w=1
AkihiroSuda
approved these changes
Jul 27, 2021
cpuguy83
requested changes
Jul 28, 2021
|
|
||
| func (p *v2Puller) pullSchema1(ctx context.Context, ref reference.Reference, unverifiedManifest *schema1.SignedManifest, platform *specs.Platform) (id digest.Digest, manifestDigest digest.Digest, err error) { | ||
| if platform != nil { | ||
| // Early bath if the requested OS doesn't match that of the configuration. |
Member
Author
There was a problem hiding this comment.
Comment was already there. I can only assume John wrote that, as it looks to be an 🇬🇧 expression https://dictionary.cambridge.org/dictionary/english/an-early-bath
|
|
||
| # Detach any VHDs | ||
| gwmi msvm_mountedstorageimage -namespace root/virtualization/v2 -ErrorAction SilentlyContinue | foreach-object {$_.DetachVirtualHardDisk() } | ||
| gwmi msvm_mountedstorageimage -namespace root/virtualization/v2 -ErrorAction SilentlyContinue | foreach-Object {$_.DetachVirtualHardDisk() } |
Member
Author
There was a problem hiding this comment.
Hmm I think that was when I fixed the alias, but I see Foreach does not have a capital here either; must've overlooked that when extracting this from the other PR
| if (-not ("$env:DOCKER_STORAGE_OPTS" -eq "")) { | ||
| Write-Host -ForegroundColor Green "INFO: Running the daemon under test with storage-driver options ${env:DOCKER_STORAGE_OPTS}" | ||
| $env:DOCKER_STORAGE_OPTS.Split(",") | ForEach { | ||
| $env:DOCKER_STORAGE_OPTS.Split(",") | ForEach-Object { |
Member
Author
There was a problem hiding this comment.
Linter complaining that Foreach is an alias, and that should not be used as it could lead to unpredictable behavior
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Splitting off more bits from #42170